This repository was archived by the owner on Nov 15, 2023. It is now read-only.
client: fix invalid node name pattern regex#14593
Merged
paritytech-processbot[bot] merged 4 commits intomasterfrom Jul 18, 2023
Merged
client: fix invalid node name pattern regex#14593paritytech-processbot[bot] merged 4 commits intomasterfrom
paritytech-processbot[bot] merged 4 commits intomasterfrom
Conversation
andresilva
added
A0-please_review
ggwpez
reviewed
Jul 17, 2023
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
approved these changes
Jul 17, 2023
Member
ggwpez
left a comment
ggwpez
left a comment
There was a problem hiding this comment.
Thanks! We will have to merge it red.
andresilva
changed the title
Contributor
|
Are other protocols' prefixes fine (like 'wss://')? |
bkchr
approved these changes
Jul 18, 2023
Member
In the end this entire check here is useless anyway, because everyone could send whatever they want to the telemetry backend. So, this here is just some kind of sanity check. |
Member
|
bot merge force |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* client: fix invalid name pattern regex * Update client/cli/src/commands/run_cmd.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * client: test node name is non-empty * client: add more tests to is_node_name_valid --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Ank4n
pushed a commit
that referenced
this pull request
Jul 22, 2023
* client: fix invalid name pattern regex * Update client/cli/src/commands/run_cmd.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * client: test node name is non-empty * client: add more tests to is_node_name_valid --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3206771.
polkadot companion: paritytech/polkadot#7484
(the companion above is fake, needed to unlock ci)