This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[fix lint warnings: NFTs pallet] fix clippy::missing_errors_doc lint warnings#14648
Merged
paritytech-processbot[bot] merged 9 commits intomasterfrom Aug 15, 2023
Merged
Conversation
sacha-l
added
A0-please_review
brunopgalvao
approved these changes
Jul 27, 2023
brunopgalvao
left a comment
brunopgalvao
left a comment
There was a problem hiding this comment.
Polishing up the docs on the NFTs pallet nice!
jsidorenko
approved these changes
Jul 27, 2023
sacha-l
commented
Jul 27, 2023
sacha-l
commented
Jul 27, 2023
sacha-l
commented
Jul 27, 2023
sacha-l
commented
Jul 27, 2023
AlexD10S
approved these changes
Jul 27, 2023
added 2 commits
August 14, 2023 18:08
ggwpez
approved these changes
Aug 14, 2023
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Contributor
Author
|
bot merge |
paritytech-processbot
bot
deleted the
sl/nfts-fix-missing_errors_doc-lint-warnings
branch
Ank4n
pushed a commit
that referenced
this pull request
Aug 20, 2023
…warnings (#14648) * fix missing errors doc warnings * cargo +nightly fmt * Update frame/nfts/src/features/create_delete_item.rs * Update frame/nfts/src/features/create_delete_item.rs * Update frame/nfts/src/features/transfer.rs * Update frame/nfts/src/features/create_delete_collection.rs * add intra doc linking for errors * fmt * Apply suggestions from code review Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the lint warnings emitted by the missing_errors_doc lint in the NFTs pallet by adding an # Errors section to the common helper functions.