Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

return proof size on manually created blocks (for tests only)#14650

Merged
bkchr merged 2 commits intoparitytech:masterfrom
moonbeam-foundation:proof-size
Aug 23, 2023
Merged

return proof size on manually created blocks (for tests only)#14650
bkchr merged 2 commits intoparitytech:masterfrom
moonbeam-foundation:proof-size

Conversation

@rimbi
Copy link
Contributor

@rimbi rimbi commented Jul 26, 2023 •
edited
Loading

Description

Return proof size on manually created blocks (for tests only)

  • What does this PR do?
    The goal of this change is to be able to get the size of the storage proof of the block in test context.
  • Why are these changes needed?
    To be able to check PoV limits in end2end tests like typescript tests
  • How were these changes implemented and what do they affect?

Checklist

  • My PR includes a detailed description as outlined in the "Description" section above
  • My PR follows the labeling requirements of this project (at minimum one label for each A, B, C and D required)

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Jul 26, 2023

User @rimbi, please sign the CLA here.

@rimbi rimbi marked this pull request as draft July 27, 2023 07:26
@rimbi rimbi marked this pull request as ready for review July 27, 2023 08:34
@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit A0-please_review Pull request needs code review. labels Aug 18, 2023
@bkchr bkchr requested a review from a team August 18, 2023 07:52
@bkchr bkchr merged commit 1631c8e into paritytech:master Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@bkchr bkchr bkchr approved these changes

@davxy davxy davxy approved these changes

@librelois librelois librelois approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rimbi @bkchr @davxy @librelois