Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

chainHead: Produce method responses on chainHead_follow#14692

Merged
lexnv merged 19 commits intomasterfrom
lexnv/chainhead_extend_resp
Aug 8, 2023
Merged

chainHead: Produce method responses on chainHead_follow#14692
lexnv merged 19 commits intomasterfrom
lexnv/chainhead_extend_resp

Conversation

@lexnv
Copy link
Contributor

@lexnv lexnv commented Jul 31, 2023 •
edited
Loading

This PR extends the chainHead_follow to produce the results of the other chainHead methods

  • chainHead_storage, chainHead_call, chainHead_body are now plain methods
  • mpsc::channel is added between the chainHead_follow and the rest of the methods
  • unique operation ID to identify the response in the chainHead_follow events is generated by the subscription management
  • BlockGuard struct is extended with the following fields:
    • the unique operation ID
    • the Sender part of the channel to communicate the response back to the chainHead_follow
  • chainHead_follow merges the Recv part of the channel to forward responses of methods back to the user
  • remove the events produced by the prior subscriptions that are now plain methods
  • testing is adjusted and added unique ID validation

Closes: #14638

// @paritytech/subxt-team

lexnv added 13 commits July 31, 2023 18:54
@lexnv
chainHead/api: Make storage/body/call pure RPC methods
4787dba 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead: Add mpsc channel between RPC methods
8050811 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead/subscriptions: Extract mpsc::Sender via BlockGuard
3b30eb3 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead/subscriptions: Generate and provide the method operation ID
d5305a9 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead: Generate chainHead_body response
50c840d 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead: Generate chainHead_call response
6c5940c 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead: Generate chainHead_storage responses
589efa8 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead: Propagate responses of methods to chainHead_follow
8062837 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead/tests: Adjust chainHead_body responses
4f7b445 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead/tests: Adjust chainHead_call responses
53fcd99 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead/tests: Adjust chainHead_call responses
167dd72 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead/tests: Ensure unique operation IDs across methods
35aca6d 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead/events: Remove old method events
008fa22 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes T2-API This PR/Issue is related to APIs. labels Jul 31, 2023
@lexnv lexnv self-assigned this Jul 31, 2023
@lexnv
Copy link
Contributor Author

lexnv commented Jul 31, 2023

bot rebase

@paritytech-processbot
Copy link

paritytech-processbot bot commented Jul 31, 2023

Rebased

@lexnv
Copy link
Contributor Author

lexnv commented Aug 1, 2023

bot rebase

@paritytech-processbot
Copy link

paritytech-processbot bot commented Aug 1, 2023

Rebased

@lexnv lexnv requested review from davxy, jsdw and skunert August 2, 2023 08:49
@lexnv lexnv mentioned this pull request Aug 2, 2023
Merged
skunert
skunert reviewed Aug 3, 2023
View reviewed changes
@lexnv lexnv requested a review from skunert August 8, 2023 13:14
jsdw
jsdw reviewed Aug 8, 2023
View reviewed changes
jsdw
jsdw reviewed Aug 8, 2023
View reviewed changes
jsdw
jsdw approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me; good job!

lexnv added 2 commits August 8, 2023 19:33
@lexnv
chainHead: Wrap subscription IDs
e189a73 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
chainHead/tests: Ensure separate operation IDs across subscriptions
83afea8 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv merged commit 25993e8 into master Aug 8, 2023
@lexnv lexnv deleted the lexnv/chainhead_extend_resp branch August 8, 2023 18:13
@lexnv lexnv mentioned this pull request Aug 9, 2023
Merged
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davxy davxy Awaiting requested review from davxy

2 more reviewers

@jsdw jsdw jsdw approved these changes

@skunert skunert skunert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lexnv lexnv

Labels

A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T2-API This PR/Issue is related to APIs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RPC-Spec-V2] Extend chainHead_follow with method responses

3 participants

@lexnv @jsdw @skunert