This repository was archived by the owner on Nov 15, 2023. It is now read-only.
feature flag to disable consequential Gov V1 hooks#14708
Closed
liamaharon wants to merge 1 commit intomasterfrom
Closed
feature flag to disable consequential Gov V1 hooks#14708liamaharon wants to merge 1 commit intomasterfrom
liamaharon wants to merge 1 commit intomasterfrom
Conversation
liamaharon
added
A0-please_review
11 tasks
liamaharon
added
A3-in_progress
Contributor
Author
|
Going to spend more time trying to remove pallets from construct_runtime! as suggested by Basti. Converting this to a draft in the meantime. |
Contributor
Author
|
Superseded by approach laid out in #14773 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paritytech/polkadot#7314 requires us to temporarily restore Gov V1 pallets to the runtime.
We need the pallets to be entirely benign.
We can disable
Callsusingexclude_parts {Call}, but still need to prevent hooks from being called.It was agreed during the last FRAME team call to add a feature flag which would disable hooks we don't want to run. There may be better approaches to disabling hooks (such as creating a new
partwe can use inexclude_parts, but that would likely take a long time to implement and unlocking the Gov V1 funds is time sensitive.