This repository was archived by the owner on Nov 15, 2023. It is now read-only.
make BagsList::put_in_front_of be permissionless#14714
Merged
paritytech-processbot[bot] merged 10 commits intomasterfrom Aug 12, 2023
Merged
make BagsList::put_in_front_of be permissionless#14714paritytech-processbot[bot] merged 10 commits intomasterfrom
BagsList::put_in_front_of be permissionless#14714paritytech-processbot[bot] merged 10 commits intomasterfrom
Conversation
kianenigma
added
A0-please_review
kianenigma
changed the title
BagsList::put_in_fron_of be permissionless
gpestana
approved these changes
Aug 4, 2023
Contributor
gpestana
left a comment
gpestana
left a comment
There was a problem hiding this comment.
I'd probably just add a simple test for the new extrinsic just to ensure that future changes do not affect the wanted behaviour.
muharem
approved these changes
Aug 7, 2023
liamaharon
approved these changes
Aug 10, 2023
jakoblell
added
D1-audited 👍
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
…ytech/substrate into kiz-permissionless-put-in-front-of
Contributor
Author
|
@snowmead @wentelteefje @aaronbassett can you do a quick review in terms of doc? This is the type of work I would love to see more of: Make a small contribution to Pallet, and use it as an excuse to learn and improve its documentation. Ofc this won't scale to all pallets in the universe, but it should help us improve the docs of the more heavily used, and recently developed ones. |
…missionless-put-in-front-of
sam0x17
reviewed
Aug 12, 2023
sam0x17
approved these changes
Aug 12, 2023
liamaharon
changed the title
BagsList::put_in_fron_of be permissionlessBagsList::put_in_front_of be permissionless
Co-authored-by: Sam Johnson <sam@durosoft.com>
…ytech/substrate into kiz-permissionless-put-in-front-of
snowmead
reviewed
Aug 12, 2023
snowmead
approved these changes
Aug 12, 2023
Co-authored-by: Michael Assaf <94772640+snowmead@users.noreply.github.com>
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
paritytech-processbot
bot
deleted the
kiz-permissionless-put-in-front-of
branch
Ank4n
pushed a commit
that referenced
this pull request
Aug 20, 2023
* make BagsList::put_in_fron_of be permissionless * Update frame/bags-list/src/lib.rs Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> * improve docs as well * update lock * Update frame/bags-list/Cargo.toml Co-authored-by: Sam Johnson <sam@durosoft.com> * fix * Update frame/bags-list/src/lib.rs Co-authored-by: Michael Assaf <94772640+snowmead@users.noreply.github.com> --------- Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: Sam Johnson <sam@durosoft.com> Co-authored-by: Michael Assaf <94772640+snowmead@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a permissionless variant of the
put_in_front_of, allowing anyone to move users within a bag.Learn more about bags and put-in-front-of: https://polkadot.network/blog/staking-update-january-2022#put-in-front-of-extrinsic
No operation is free in this process.
Moving within the bag is only possible if you are being strictly moved to a better position. But there is no guarantee that you will be moved to the best possibly position.
I kept the old transaction untouched to not break any existing UIs.
This new transaction should be integrated into https://github.com/paritytech/polkadot-scripts, and run as a bot by w3f.