This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Update Scheduler Pallet Documentation#14740
Merged
paritytech-processbot[bot] merged 13 commits intoparitytech:masterfrom Aug 15, 2023
snowmead:snowmead-scheduler-pallet-security-doc
Merged
Update Scheduler Pallet Documentation#14740paritytech-processbot[bot] merged 13 commits intoparitytech:masterfrom snowmead:snowmead-scheduler-pallet-security-doc
paritytech-processbot[bot] merged 13 commits intoparitytech:masterfrom
snowmead:snowmead-scheduler-pallet-security-doc
Conversation
Contributor
|
there is a new documentation guidelines you might wanna check https://github.com/paritytech/substrate/blob/master/docs/DOCUMENTATION_GUIDELINES.md |
kilogold
reviewed
Aug 12, 2023
Contributor
kilogold
left a comment
kilogold
left a comment
There was a problem hiding this comment.
I like what I'm seeing here.
Co-authored-by: Kelvin Bonilla <bonilla_kelvin@hotmail.com>
KiChjang
reviewed
Aug 12, 2023
KiChjang
reviewed
Aug 12, 2023
KiChjang
reviewed
Aug 12, 2023
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
kianenigma
added
A0-please_review
kianenigma
reviewed
Aug 14, 2023
kianenigma
reviewed
Aug 14, 2023
kianenigma
reviewed
Aug 14, 2023
kianenigma
reviewed
Aug 14, 2023
kianenigma
reviewed
Aug 14, 2023
kianenigma
approved these changes
Aug 14, 2023
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Some suggestions, but all in all looks good!
Ammend comments related to documentation
sam0x17
approved these changes
Aug 14, 2023
Contributor
sam0x17
left a comment
sam0x17
left a comment
There was a problem hiding this comment.
few grammar / wording nits, then looks good
muharem
reviewed
Aug 14, 2023
Co-authored-by: Nate Armstrong <naterarmstrong@gmail.com>
KiChjang
approved these changes
Aug 15, 2023
wentelteefje
approved these changes
Aug 15, 2023
gilescope
approved these changes
Aug 15, 2023
Contributor
|
bot merge |
Ank4n
pushed a commit
that referenced
this pull request
Aug 20, 2023
* Update pallet scheduler documentation, warning section, guidelines update * Update call filter note Co-authored-by: Kelvin Bonilla <bonilla_kelvin@hotmail.com> * revert format cargo * Doc wording Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Doc wording Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Ammend comments related to documentation * Include additional warning section in `on_initialize` hook * Amend doc Co-authored-by: Sam Johnson <sam@durosoft.com> * Amend doc Co-authored-by: Sam Johnson <sam@durosoft.com> * Move no_std to appropriate place * Amend doc Co-authored-by: Nate Armstrong <naterarmstrong@gmail.com> * Amend comment Co-authored-by: Nate Armstrong <naterarmstrong@gmail.com> --------- Co-authored-by: Kelvin Bonilla <bonilla_kelvin@hotmail.com> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: Sam Johnson <sam@durosoft.com> Co-authored-by: Nate Armstrong <naterarmstrong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the documentation of the Scheduler Pallet based on pallet documentation guidelines.
Warning section added to inform users of some anti-patterns when scheduling runtime calls due to misconceptions of the pallet.
Closes #14715