This repository was archived by the owner on Nov 15, 2023. It is now read-only.
sc-consensus-beefy: fix BEEFY fast sync#14752
Merged
acatangiu merged 1 commit intoparitytech:masterfrom Aug 11, 2023
Merged
Conversation
acatangiu
added
A0-please_review
serban300
approved these changes
Aug 11, 2023
lexnv
approved these changes
Aug 11, 2023
andresilva
approved these changes
Aug 11, 2023
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
lgtm. just a small safety suggestion
acatangiu
force-pushed
the
fix-beefy-fast-sync
branch
from
fb5733c to
cd715e6
Compare
…ilable When BEEFY voter is initialized from scratch (no aux db persistent data present), it needs to find BEEFY genesis block and all subsequent Mandatory blocks and sync justifications for them. The initialization code was getting active validator sets for these older blocks from state, but in cases such as 'fast sync', state is unavailable. This commit adds a fallback initialization mechanism when state is unavailable: parse header Digests looking for validator set change log deposits. Signed-off-by: Adrian Catangiu <adrian@parity.io>
acatangiu
force-pushed
the
fix-beefy-fast-sync
branch
from
cd715e6 to
16824bb
Compare
andresilva
approved these changes
Aug 11, 2023
Ank4n
pushed a commit
that referenced
this pull request
Aug 20, 2023
…ilable (#14752) When BEEFY voter is initialized from scratch (no aux db persistent data present), it needs to find BEEFY genesis block and all subsequent Mandatory blocks and sync justifications for them. The initialization code was getting active validator sets for these older blocks from state, but in cases such as 'fast sync', state is unavailable. This commit adds a fallback initialization mechanism when state is unavailable: parse header Digests looking for validator set change log deposits. Signed-off-by: Adrian Catangiu <adrian@parity.io>
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When BEEFY voter is initialized from scratch (no aux db persistent data present), it needs to find BEEFY genesis block and all subsequent Mandatory blocks and sync justifications for them.
The initialization code was getting active validator sets for these older blocks from state, but in cases such as 'fast sync', state is unavailable.
This commit adds a fallback initialization mechanism when state is unavailable: parse header Digests looking for validator set change log deposits.