Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Revert "sc-cli: add no-beefy flag to cli config (#14754)"#14766

Merged
paritytech-processbot[bot] merged 1 commit intoparitytech:masterfrom
acatangiu:sc-cli-beefy-flag
Aug 15, 2023
Merged

Revert "sc-cli: add no-beefy flag to cli config (#14754)"#14766
paritytech-processbot[bot] merged 1 commit intoparitytech:masterfrom
acatangiu:sc-cli-beefy-flag

Conversation

@acatangiu
Copy link
Contributor

@acatangiu acatangiu commented Aug 14, 2023 •
edited
Loading

This reverts commit 2060c36.

Based on #14754 (comment)

polkadot companion: paritytech/polkadot#7613
cumulus companion: paritytech/cumulus#3007

@acatangiu acatangiu added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 14, 2023
@acatangiu acatangiu requested review from bkchr, lexnv and serban300 August 14, 2023 15:45
@acatangiu acatangiu self-assigned this Aug 14, 2023
This was referenced Aug 14, 2023
Merged
Merged
@acatangiu
Copy link
Contributor Author

acatangiu commented Aug 14, 2023

@bkchr

I know that we also have there disable_grandpa, that is just some old oversight and we should not replicate it.

shall I also remove disable_grandpa then (remove --no-grandpa from sc-cli)? If yes, will do it as separate PR so that this is clean revert and nothing else.

@bkchr
Copy link
Member

bkchr commented Aug 15, 2023

@bkchr

I know that we also have there disable_grandpa, that is just some old oversight and we should not replicate it.

shall I also remove disable_grandpa then (remove --no-grandpa from sc-cli)? If yes, will do it as separate PR so that this is clean revert and nothing else.

Sounds like a good idea! WDYT @andresilva?

@acatangiu
Copy link
Contributor Author

acatangiu commented Aug 15, 2023

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented Aug 15, 2023

Error: Github API says paritytech/polkadot#7613 is not mergeable

@andresilva
Copy link
Contributor

andresilva commented Aug 15, 2023 •
edited
Loading

The disable_grandpa flag is used in both the node and node-template services, those are just using directly the RunCmd from sc-cli and it's probably not worth it to create their own RunCmd structs just for this. I'm fine with removing it, but it should still be added to polkadot IMO.

@acatangiu
Copy link
Contributor Author

acatangiu commented Aug 15, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 8a2c265 into paritytech:master Aug 15, 2023
Ank4n pushed a commit that referenced this pull request Aug 20, 2023
@acatangiu @Ank4n
Revert "sc-cli: add no-beefy flag to cli config (#14754)" (#14766)
28afcb8 
This reverts commit 2060c36.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@andresilva andresilva andresilva approved these changes

@bkchr bkchr bkchr approved these changes

@serban300 serban300 serban300 approved these changes

@lexnv lexnv lexnv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@acatangiu acatangiu

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@acatangiu @bkchr @andresilva @serban300 @lexnv