This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Contracts: Update Config::Debug#14789
Merged
paritytech-processbot[bot] merged 26 commits intomasterfrom Aug 24, 2023
Merged
Conversation
pgherveou
changed the title
pgherveou
added
A0-please_review
pgherveou
changed the title
pgherveou
commented
Aug 21, 2023
Contributor
Author
|
@athei moved back everything under the Debugging umbrella trait, and used back T::Debug associated trait name. |
juangirini
approved these changes
Aug 22, 2023
athei
approved these changes
Aug 23, 2023
pgherveou
added
B1-note_worthy
Contributor
Author
|
@oleg-plakida you mind giving us a +1 here for removing the |
Contributor
Author
alvicsam
approved these changes
Aug 23, 2023
Contributor
Author
|
bot merge |
|
Error: Statuses failed for 986fe10 |
pgherveou
commented
Aug 23, 2023
sergejparity
approved these changes
Aug 24, 2023
Contributor
Author
|
bot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
Debugtrait that was behind theunsafe-debugfeature flag, and get rid of the feature flagMost config should set it to
()that will simply log contract calls whenruntime::contractslog target is set to trace.More advanced debugging tools can leverage this trait to introduce more sophisticated observability behaviors.
See previous PR (#14678) for more context.
Cumulus companion: paritytech/cumulus#3035