This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[NFTs] Make owned_item in MintWitness optional#14800
Merged
paritytech-processbot[bot] merged 2 commits intomasterfrom Aug 21, 2023
Merged
[NFTs] Make owned_item in MintWitness optional#14800paritytech-processbot[bot] merged 2 commits intomasterfrom
paritytech-processbot[bot] merged 2 commits intomasterfrom
Conversation
jsidorenko
added
A0-please_review
gilescope
approved these changes
Aug 21, 2023
ggwpez
approved these changes
Aug 21, 2023
Contributor
Author
|
bot rebase |
|
Rebased |
Contributor
Author
|
bot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
MintWitnessobject, all the fields are supposed to be optional.We validate them depending on the collection settings:
MintWitness.owned_itemwhen themint_type= HolderOf andMintWitness.mint_pricewhen the mint price is set.