This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
stanislav-tkach
added
A0-please_review
Contributor
Author
|
I'm going to update the pull request after #1757 in order to reduce renaming ( |
stanislav-tkach
force-pushed
the
stas-2018
branch
from
5bc8cc2 to
9c39545
Compare
stanislav-tkach
force-pushed
the
stas-2018
branch
4 times, most recently
from
f18ed94 to
3ab3a12
Compare
stanislav-tkach
force-pushed
the
stas-2018
branch
from
3ab3a12 to
e361b28
Compare
stanislav-tkach
added
A0-please_review
Contributor
Author
|
Updated. |
gavofyork
approved these changes
Feb 13, 2019
gavofyork
added
A8-looksgood
and removed
A0-please_review
Closed
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All
extern crate's are removed (excepttest,allocandproc_macro).The only exception is
core/finality-grandpain order to simplify back-porting from thealexander-backportsbranch. I suppose it makes sense to cover it in a separate issue.Closes #1415.