Conversation
srml/fees/src/lib.rs
Outdated
| let new_fee = current_fee.checked_add(&amount).ok_or_else(|| "fee got overflow after charge")?; | ||
|
|
||
| T::TransferAsset::withdraw(transactor, amount, WithdrawReason::TransactionPayment)?; | ||
| T::TransferAsset::withdraw(transactor, amount, WithdrawReason::Reserve)?; |
|
I think the All in all, I would propose to revert the fees module entirely (it was merged without my consent in the first place) and instead introduce a number of ZCAs in any existing modules that do things that you'd want to catch and potentially handle differently. This could include, e.g. Balance module making a new account or transfer charge. There can then be a fees module introduced which can be hooked into all of these events without compromising the performance or API hygiene of the main SRML modules. |
|
@gavofyork I have removed the |
|
#2028 is the way things need to go. This removes all the fees stuff, replacing With all the abstractions I introduce in #2028, you should still be able to do everything you need, including a fairly holistic fees amalgamation module. |
Closes #1993