Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
| /// Get a trie id (trie id must be unique and collision resistant depending upon its context). | ||
| /// Note that it is different than encode because trie id should be collision resistant | ||
| /// (being a proper uniqueid). | ||
| pub trait TrieIdGenerator<AccountId> { |
There was a problem hiding this comment.
A bit out of scope, but I'm not sure this should be named "Trie". The trie is an abstraction level beyond storage and is an implementation detail as far as the runtime module is concerned. In this case, it's specifically the AccountId that must be a unique identifier, so it should probably be called AccountIdGenerator
cc @pepyakin
|
Fixed review comments with the exception of Have changed "To use it in your module..." to "To use it in your runtime..." for modules except the System module, as I think it applies more to modules than runtimes. Correct? |
| //! # Contract Module | ||
| //! | ||
| //! The contract module provides functionality for the runtime to deploy and execute WebAssembly smart-contracts. | ||
| //! The supported dispatchable functions are documented as part of the [`Call`](./enum.Call.html) enum. |
There was a problem hiding this comment.
Why did you remove the Call enum here?
There was a problem hiding this comment.
I moved it to the Dispatchable Functions section so that you see a link from the brief summaries to the more detailed documentation. This is also consistent with where other modules have put this link.
| //! You can start using the sudo module by implementing the sudo [`Trait`]. | ||
| //! | ||
| //! Supported dispatchable functions are documented in the [`Call`] enum. | ||
| //! You can start using the Sudo module by implementing the [`sudo::Trait`](./trait.Trait.html). |
Co-Authored-By: joepetrowski <25483142+joepetrowski@users.noreply.github.com>
shawntabrizi
added
A0-please_review
6 participants
Closes #2159
Updates:
Balances
Contract
Staking
Sudo & System
Timestamp