This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
…te into make-examples-compile
…/substrate into make-examples-compile
joepetrowski
added
A3-in_progress
bkchr
reviewed
Apr 17, 2019
srml/balances/src/lib.rs
Outdated
| //! T::BlockNumber::max_value(), | ||
| //! WithdrawReasons::all() | ||
| //! ); | ||
| //! // <Ledger<T>>::insert(controller, ledger); // Commented out as we don't have acces to Staking's storage here. |
Member
There was a problem hiding this comment.
Maybe use a different example here? Or just drop the last line?
Contributor
Author
There was a problem hiding this comment.
Yeah, I looked a lot. The problem is the nature of Currency in general, in that if you are locking or transferring funds, you are probably doing a lot of checks and/or writing to storage because the currency event was in response to some other event (like seconding a referendum). I'm OK with removing it.
Contributor
|
consensus compiles at least but I think the doc example could be improved and maybe some removed |
Contributor
Author
|
In staking, I removed a lot of examples that were just taken from the test file and require a large mock environment to compile. Open to re-introducing them if people think they are useful. |
ltfschoen
added a commit
that referenced
this pull request
Apr 17, 2019
joepetrowski
added
A0-please_review
shawntabrizi
approved these changes
Apr 18, 2019
bkchr
approved these changes
Apr 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make documentation examples compile for the following modules: