This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Forward port blake2 storage support#2360
Merged
Conversation
* remove default hash, introduce twox_128 and blake2 * use blake2_128 & create ext_blake2_128 * refactor code * add benchmark * factorize generator * fix * parameterizable hasher * some fix * fix * fix * fix * metadata * fix * remove debug print * map -> blake2_256 * fix test * fix test * Apply suggestions from code review Co-Authored-By: thiolliere <gui.thiolliere@gmail.com> * impl twox 128 concat (#2353) * impl twox_128_concat * comment addressed * fix * impl twox_128->64_concat * fix test
gui1117
approved these changes
Apr 24, 2019
Contributor
gui1117
left a comment
gui1117
left a comment
There was a problem hiding this comment.
some insubstancial comments. Everything seems good
| input.to_vec() | ||
| }, | ||
| test_blake2_256 => |input| blake2_256(input).to_vec(), | ||
| test_blake2_128 => |input| blake2_128(input).to_vec(), |
Contributor
There was a problem hiding this comment.
did I forget test_twox_64 as well ?
| groups_impl!(Parens, Paren, Parenthesis, parse_parens); | ||
|
|
||
| #[derive(Debug)] | ||
| #[derive(Debug, Clone)] |
Contributor
There was a problem hiding this comment.
hmm I now remember I introduced this Clone before creating the new enum HasherKind. So I very suspect this change is not needed anymore.
Member
Author
There was a problem hiding this comment.
As we will remove this anyway, it is no problem.
Co-Authored-By: bkchr <bkchr@users.noreply.github.com>
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Jul 10, 2019
* move storage maps to blake2_128 (paritytech#2268) * remove default hash, introduce twox_128 and blake2 * use blake2_128 & create ext_blake2_128 * refactor code * add benchmark * factorize generator * fix * parameterizable hasher * some fix * fix * fix * fix * metadata * fix * remove debug print * map -> blake2_256 * fix test * fix test * Apply suggestions from code review Co-Authored-By: thiolliere <gui.thiolliere@gmail.com> * impl twox 128 concat (paritytech#2353) * impl twox_128_concat * comment addressed * fix * impl twox_128->64_concat * fix test * Fix compilation and cleanup some docs * Apply suggestions from code review Co-Authored-By: bkchr <bkchr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2268