This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
Contributor
Contributor
Author
|
Decided to remove penalty from |
tomaka
approved these changes
May 8, 2019
andresilva
approved these changes
May 8, 2019
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Jul 10, 2019
* ignore light nodes in ConsensusGossip * fixed method name * temporary disabled penalty when block is announced * remove traces of BLOCK_ANNOUNCE_REPUTATION_CHANGE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 3 issues currently (each one takes its own commit):
ConsensusGossip- think that is the correct way;LightCallExecutor::version- instead of "version" it should call "Core_version". Currently aura verifier calls this - that should be fixed by Light GRANDPA import handler #1669 ;BLOCK_ANNOUNCE_REPUTATION_CHANGEstates that 'Since this has a small cost, we decrease the reputation of the node, and will increase it back later if the import is successful.' - I haven't found that. Could you, please, point me to that code? Probably it isn't executed on light, because I have seen on-announce-disconnects even after peer has provided us with several valid blocks.Adding suggested reviewers to the PR (skipping Rob :) ).
Cc @andresilva and @niklasad1 (I'm not sure, but the second issue could be the issue you have found today as well).