This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
bkchr
approved these changes
May 29, 2019
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
You would need to increase the spec_version. This will also break the current test net. Cc @andresilva
Contributor
|
There's #2466 that will break compatibility as well. Here's my opinion on it: #2466 (comment). What's your opinion? |
Member
|
I'm for breaking, instead of managing some backwards compatibility. :) |
andresilva
approved these changes
May 29, 2019
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Jul 10, 2019
* derive codec for inherent data * increase spec version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2710