This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Closed
Conversation
bkchr
reviewed
Jun 3, 2019
bkchr
reviewed
Jun 3, 2019
605701a to
d048be1
Compare
Member
|
This isn't quite right. Is it only meant as the first step with several follow-up PRs yet to come? Staking shouldn't be implementing or responding to |
Contributor
Author
|
Is SessionWillEnd distinct from OnSessionChange? |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of forcing a new era when the staking module slashes a validator it disables the validator. The default implementation for this forces a new era, but the babe module should be able to do it's own book keeping.