Initial mechanics for 80:20 fee split by gavofyork · Pull Request #2912 · paritytech/substrate

gavofyork · 2019-06-19T23:26:39Z

Also:

Introduce extra functions for Imbalance manipulation;
Store treasury pot in an account, letting total issuance account for it;
Make parity-codec versions consistent.

TODO:

Make Author trait work in order to provide funds to the block author. This is blocked on PreRuntime Digests: Extract authorship information on the runtime side #2918. Might be worth getting this PR in in the meantime nonetheless. Also see Generic authorship and uncle inclusion module #2941, BABE Randomness using PreRuntime digests #2929.

Also: - Introduce extra functions for Imbalance manipulation; - Store treasury pot in an account, letting total issuance account for it.

* Update parity-codec version * Update grandpa, rhododendron and trie-bench * Use primitive-types from crates.io * Bump impl version * Fix trie-bench version * Fix lock files * Fix versions * Update codec to 4.1

niklasad1 · 2019-06-25T20:15:36Z

@gavofyork This PR contains a lot of unrelated changes probably because parity codec version was reverted.

It is very hard to review, can you fix the unrelated changes?

node/runtime/src/lib.rs

srml/treasury/src/lib.rs

rphmeier · 2019-06-26T10:07:32Z

Make Author trait work in order to provide funds to the block author. This is blocked on #2918.

You can block on #2941 instead and call <authorship::Module<T>>::author() where T has a dummy FindAuthor implementation rather than a real one

Co-Authored-By: DemiMarie-parity <48690212+DemiMarie-parity@users.noreply.github.com>

gavofyork · 2019-07-01T16:00:34Z

@niklasad1 should be easier now.

core/sr-primitives/src/traits.rs

rphmeier · 2019-07-01T16:08:52Z

srml/treasury/src/lib.rs

 type PositiveImbalanceOf<T> = <<T as Trait>::Currency as Currency<<T as system::Trait>::AccountId>>::PositiveImbalance;
 type NegativeImbalanceOf<T> = <<T as Trait>::Currency as Currency<<T as system::Trait>::AccountId>>::NegativeImbalance;

+const MODULE_ID: ModuleId = ModuleId(*b"py/trsry");


what is py?

Co-Authored-By: Robert Habermeier <rphmeier@gmail.com>

…80-20

* Initial mechanics for 80:20 fee split Also: - Introduce extra functions for Imbalance manipulation; - Store treasury pot in an account, letting total issuance account for it. * Fix some tests * Fix some tests * Minor cleanups * Update parity-codec version (#2855) * Update parity-codec version * Update grandpa, rhododendron and trie-bench * Use primitive-types from crates.io * Bump impl version * Fix trie-bench version * Fix lock files * Fix versions * Update codec to 4.1 * merge fix * Revert merge * More reversions * Remove accidental code * Update locks * Bump runtime * Update locks * Tweaks and label TODO * Update srml/treasury/src/lib.rs Co-Authored-By: DemiMarie-parity <48690212+DemiMarie-parity@users.noreply.github.com> * Update issue number * Update core/sr-primitives/src/traits.rs Co-Authored-By: Robert Habermeier <rphmeier@gmail.com> * Fix wasm build * Fix subkey build

* Initial mechanics for 80:20 fee split Also: - Introduce extra functions for Imbalance manipulation; - Store treasury pot in an account, letting total issuance account for it. * Fix some tests * Fix some tests * Minor cleanups * Update parity-codec version (paritytech#2855) * Update parity-codec version * Update grandpa, rhododendron and trie-bench * Use primitive-types from crates.io * Bump impl version * Fix trie-bench version * Fix lock files * Fix versions * Update codec to 4.1 * merge fix * Revert merge * More reversions * Remove accidental code * Update locks * Bump runtime * Update locks * Tweaks and label TODO * Update srml/treasury/src/lib.rs Co-Authored-By: DemiMarie-parity <48690212+DemiMarie-parity@users.noreply.github.com> * Update issue number * Update core/sr-primitives/src/traits.rs Co-Authored-By: Robert Habermeier <rphmeier@gmail.com> * Fix wasm build * Fix subkey build

Initial mechanics for 80:20 fee split

1c229a3

Also: - Introduce extra functions for Imbalance manipulation; - Store treasury pot in an account, letting total issuance account for it.

gavofyork added the A3-in_progress Pull request is in progress. No review needed at this stage. label Jun 19, 2019

devops-parity added the A4-gotissues label Jun 19, 2019

gavofyork added 4 commits June 24, 2019 23:06

Fix some tests

f68371f

Merge remote-tracking branch 'origin' into gav-80-20

c0c7ca2

Fix some tests

a982fe4

Minor cleanups

c766b28

gavofyork added A0-please_review Pull request needs code review. and removed A4-gotissues A3-in_progress Pull request is in progress. No review needed at this stage. labels Jun 25, 2019

devops-parity added the B2-breaksapi label Jun 25, 2019

stanislav-tkach and others added 3 commits June 25, 2019 12:03

Update parity-codec version (#2855)

96e17dc

* Update parity-codec version * Update grandpa, rhododendron and trie-bench * Use primitive-types from crates.io * Bump impl version * Fix trie-bench version * Fix lock files * Fix versions * Update codec to 4.1

Merge remote-tracking branch 'origin/master' into gav-80-20

42ed92f

merge fix

d7c96df

gavofyork force-pushed the master branch from 96e17dc to 1c2eaa3 Compare June 25, 2019 11:29

gavofyork added 8 commits June 25, 2019 13:50

Revert merge

92c9a99

More reversions

d9ef704

Remove accidental code

e45ca9b

Update locks

42561d6

Bump runtime

e4c4f04

Update locks

f8c5720

Tweaks and label TODO

6c7618c

Merge remote-tracking branch 'origin/master' into gav-80-20

85903b5

Demi-Marie reviewed Jun 25, 2019

View reviewed changes

node/runtime/src/lib.rs Outdated Show resolved Hide resolved

srml/treasury/src/lib.rs Outdated Show resolved Hide resolved

gavofyork and others added 2 commits July 1, 2019 17:08

Update srml/treasury/src/lib.rs

85491bc

Co-Authored-By: DemiMarie-parity <48690212+DemiMarie-parity@users.noreply.github.com>

Merge remote-tracking branch 'origin/master' into gav-80-20

f7c6aff

Update issue number

66cfeac

rphmeier reviewed Jul 1, 2019

View reviewed changes

core/sr-primitives/src/traits.rs Outdated Show resolved Hide resolved

rphmeier reviewed Jul 1, 2019

View reviewed changes

rphmeier approved these changes Jul 1, 2019

View reviewed changes

gavofyork and others added 4 commits July 1, 2019 19:54

Update core/sr-primitives/src/traits.rs

9d6e643

Co-Authored-By: Robert Habermeier <rphmeier@gmail.com>

Fix wasm build

a8485d9

Merge branch 'gav-80-20' of github.com:paritytech/substrate into gav-…

619b24d

…80-20

Fix subkey build

a6dfea4

gavofyork merged commit c3f6617 into master Jul 2, 2019

gavofyork deleted the gav-80-20 branch July 2, 2019 09:41

kianenigma mentioned this pull request Jul 21, 2019

Transaction Fees: 80% to treasury, 20% to block producer #2769

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial mechanics for 80:20 fee split#2912

Initial mechanics for 80:20 fee split#2912
gavofyork merged 23 commits intomasterfrom
gav-80-20

gavofyork commented Jun 19, 2019 •

edited

Loading

Uh oh!

niklasad1 commented Jun 25, 2019

Uh oh!

Uh oh!

Uh oh!

rphmeier commented Jun 26, 2019 •

edited

Loading

Uh oh!

gavofyork commented Jul 1, 2019

Uh oh!

Uh oh!

rphmeier Jul 1, 2019

Uh oh!

gavofyork Jul 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

gavofyork commented Jun 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

niklasad1 commented Jun 25, 2019

Uh oh!

Uh oh!

Uh oh!

rphmeier commented Jun 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gavofyork commented Jul 1, 2019

Uh oh!

Uh oh!

rphmeier Jul 1, 2019

Choose a reason for hiding this comment

Uh oh!

gavofyork Jul 1, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gavofyork commented Jun 19, 2019 •

edited

Loading

rphmeier commented Jun 26, 2019 •

edited

Loading