This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Operational Transaction signed extension.#3128
Closed
kianenigma wants to merge 7 commits intogav-extensble-transactionsfrom
Closed
Operational Transaction signed extension.#3128kianenigma wants to merge 7 commits intogav-extensble-transactionsfrom
kianenigma wants to merge 7 commits intogav-extensble-transactionsfrom
Conversation
11 tasks
Member
why would it do this? wouldn't that make the transaction free? what stops a dos/sybil attack? |
Contributor
Author
|
This needs to be started over again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
built on top of #3115 and should be updated with it. Should only be marge after #3115 is merged.
#[weight]to a more generalized#[meta]tag which can carry static information about both weight, priority and basic functions on top of them. (pub type CallDescriptor = (Weight, TransactionPriority);-- okay name?)weightin the code to the more general structure.Gist of the change being:
where setting
#[meta = WeightedTransaction::Operational()]simply boosts to your priority to infinity and drops your weight toZeroetc.TODO:
CallMetadatato definewill_cause_full_block()to guarantee operational txs will go through.I will mark this as in-progress now since reviewing it is moot with the additional commits of #3115.
Also closes #3106