This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Synchronize state cache on finalization#3246
Merged
andresilva merged 6 commits intomasterfrom Jul 30, 2019
Merged
Conversation
bkchr
reviewed
Jul 30, 2019
andresilva
approved these changes
Jul 30, 2019
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
LGTM. I could not replicate the state issue running with this PR.
andresilva
added
A8-looksgood
and removed
A0-please_review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache is not currently updated to match the best state when re-org is caused by setting finality, and not by importing a block.
Also fixed informant reporting false re-orgs.