Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

node: use BABE predigest data to find authorship#3293

Merged
gavofyork merged 3 commits intomasterfrom
andre/node-runtime-find-author
Aug 2, 2019
Merged

node: use BABE predigest data to find authorship#3293
gavofyork merged 3 commits intomasterfrom
andre/node-runtime-find-author

Conversation

@andresilva
Copy link
Contributor

@andresilva andresilva commented Aug 2, 2019

We already had all the infrastructure in place to collect authorship data from BABE predigests but it wasn't wired in on the node runtime.

Fixes #2986.

@andresilva andresilva added A0-please_review Pull request needs code review. M4-core labels Aug 2, 2019
@andresilva
Copy link
Contributor Author

I changed the FindAuthor session adapter to use a u64 for authority index because that's what BABE uses. But maybe it's more reasonable to instead have BABE use a u32 instead.

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet.

@rphmeier rphmeier added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 2, 2019
@rphmeier
Copy link
Contributor

rphmeier commented Aug 2, 2019

I changed the FindAuthor session adapter to use a u64 for authority index because that's what BABE uses. But maybe it's more reasonable to instead have BABE use a u32 instead.

We've bounded the length of authority lists by u32 elsewhere, so I don't think this would be controversial.

@andresilva
Copy link
Contributor Author

Updated BABE to use u32 for authority index, this breaks sync with FF but there are more breaking changes on the pipeline and we will reset FF shortly anyway.

@andresilva andresilva force-pushed the andre/node-runtime-find-author branch from 85875cb to c109db0 Compare August 2, 2019 17:26
@gavofyork gavofyork merged commit 3181e0c into master Aug 2, 2019
@gavofyork gavofyork deleted the andre/node-runtime-find-author branch August 2, 2019 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Aura authorship-detection to Pre-runtime digests

5 participants