Conversation
twittner
left a comment
There was a problem hiding this comment.
I think is_idle is touched in too many places and is too fragile to use. If only one self.is_idle = false is missing, block_requests will not function properly. Rather than introducing this flag I would consider removing the line trace!(target: "sync", "No new block request for {}", id);.
Generally speaking I think we should make more use of the available log levels. I think it is okay for trace to produce a lot of output as it is meant to literally trace through the whole processing flow as it happens. We seem to be using info only rarely if at all so everything informational ends up in debug or trace. Maybe lifting most of debug to info and some of trace to debug would leave room for the truly noisy messages to be left on trace level.
|
|
* Cache idle state * Display import error by default
Fixes #3269