This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
bkchr
approved these changes
Aug 9, 2019
rphmeier
approved these changes
Aug 9, 2019
rphmeier
added
A8-looksgood
and removed
A0-please_review
marcio-diaz
pushed a commit
that referenced
this pull request
Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we run with GRANDPA disabled besides registering the finality tracker inherent provider we must also register a gossip validator for GRANDPA messages, otherwise we will ban peers who send us GRANDPA
Neighbormessages since there's no validator associated with consensus engine id of message. I added a validator that just discards all messages. I tested this locally with 2 authorities (one running with--no-grandpa) and it works correctly now.