This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
rphmeier
added
the
A3-in_progress
rphmeier
added
A0-please_review
gavofyork
reviewed
Jan 20, 2018
| local_candidate | ||
| .into_future() | ||
| .map(table::Statement::Candidate) | ||
| .map(Some) |
Member
There was a problem hiding this comment.
Are these two lines moot or am I missing something?
Contributor
Author
There was a problem hiding this comment.
it's necessary for the or_else in the next line which is currently used to swallow errors in candidate production.
gavofyork
reviewed
Jan 20, 2018
| let table = params.table; | ||
| params.timer.interval(params.form_proposal_interval) | ||
| .map_err(|_| Error::FaultyTimer) | ||
| .for_each(move |_| { table.update_proposal(); Ok(()) }) |
Member
There was a problem hiding this comment.
could be written .for_each(move |_| Ok(table.update_proposal())) which is a bit more concise.
gavofyork
approved these changes
Jan 20, 2018
Member
gavofyork
left a comment
gavofyork
left a comment
There was a problem hiding this comment.
quality looks good but haven't done deep review of logic.
JoshOrndorff
referenced
this pull request
in moonbeam-foundation/substrate
Apr 21, 2021
Fix serialize-javascript vulnerability alert
imstar15
pushed a commit
to imstar15/substrate
that referenced
this pull request
Jan 3, 2023
…xecution-benchmarks introduce compile time switch for omitting extrinsics execution
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
…ech#34) * Update default runtime types to match latest substrate * Format code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
The previous PR (#29) implemented the core primitives for achieving consensus. This one wraps them one step further by
The next consensus PR will combine the networking code and the runtime from #32 with the code in the
candidate-agreementmodule.