This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
bkchr
approved these changes
Oct 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
default-runis stable (rust-lang/cargo#7056), I'd like to revisit #3192.But before re-doing #3192, I'm opening this PR as a preliminary change.
This PR slightly changes the organization of the repo.
Instead of having a root package named "substrate" with a binary, the root
Cargo.tomlis now purely a virtual workspace. The package named "substrate" no longer exists.Instead, the Substrate node is now a binary named "substrate" contained within the
node-clipackage (directorynode/cli).Thanks to the now-stable
default-runfeature, doingcargo runat the root automatically runs this binary.One possible breaking change is that
cargo b --package substratewill no longer work (as the "substrate" package disappeared), but I don't think anyone was doing that, and I don't see the point in doing that. The rest should stay entirely the same. Most notably, the binary is still located at./target/debug/substrateor./target/release/substrate.