This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Closed
Conversation
complete some test method by providing child access to values.
is. Need to use historied values, maybe remove pinned, and put some context as parameter for get_offstate
probably need to store state, apply gc on state and depending on result restore state or actually gc historied values.
should get updated.
for gc. Need to change commit set to contain an history of values and adjust test db.
Co-Authored-By: thiolliere <gui.thiolliere@gmail.com>
Break big line.
gui1117
reviewed
Nov 5, 2019
gui1117
reviewed
Nov 6, 2019
| } | ||
|
|
||
| /// Get backend storage reference. | ||
| pub fn backend_storage(&self) -> &S { |
Contributor
There was a problem hiding this comment.
Suggested change
| pub fn backend_storage(&self) -> &S { | |
| pub fn trie_backend_storage(&self) -> &S { |
| } | ||
|
|
||
| /// Consumes self and returns underlying storage. | ||
| pub fn into_storage(self) -> S { |
Contributor
There was a problem hiding this comment.
Suggested change
| pub fn into_storage(self) -> S { | |
| pub fn into_trie_storage(self) -> S { |
gui1117
reviewed
Nov 6, 2019
and few doc and naming changes.
Contributor
Author
|
Closing this PR because Child trie associated issue will be work around in a way that does not require this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extract the state machine logic from #3774 to try to make it more reviewable.
For general goal of key value storage, please refer to #3774.
This PR cover state machine and its new backend use to handle non state key values.
This is a very limited interface but a next step could be to extend api with the ability to chose a 'collection' (#3774 first target is purely technical : keyspace for child trie, but it could be extended, for instance we could push events targeting offchain).