This repository was archived by the owner on Nov 15, 2023. It is now read-only.
*: Register network event stream for authority discovery#4344
Merged
gavofyork merged 1 commit intoparitytech:masterfrom Jan 3, 2020
Merged
*: Register network event stream for authority discovery#4344gavofyork merged 1 commit intoparitytech:masterfrom
gavofyork merged 1 commit intoparitytech:masterfrom
Conversation
mxinden
added
the
A3-in_progress
This was referenced Dec 10, 2019
Previously one would create a sender and receiver channel pair, pass the sender to the `build_network_future` through the service builder and funnel network events returned from polling the network service into the sender to be consumed by the authority discovery module owning the receiver. With recent changes it is now possible to register an `event_stream` with the network service directly, thus one does not need to make the detour through the `build_network_future`.
mxinden
force-pushed
the
extract-gossip-authority-discovery
branch
from
c01d712 to
bf750b6
Compare
mxinden
added
A0-please_review
tomaka
approved these changes
Jan 3, 2020
Contributor
tomaka
left a comment
tomaka
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up! It's cool that we get rid of this code before it reaches the point where nobody knows why it's there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #4284.
Previously one would create a sender and receiver channel pair, pass the
sender to the
build_network_futurethrough the service builder andfunnel network events returned from polling the network service into the
sender to be consumed by the authority discovery module owning the
receiver.
With recent changes it is now possible to register an
event_streamwith the network service directly, thus one does not need to make the
detour through the
build_network_future.