This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
expenses
changed the title
sc-service to 0.3 futures
tomaka
suggested changes
Jan 3, 2020
tomaka
suggested changes
Jan 3, 2020
tomaka
approved these changes
Jan 6, 2020
Contributor
Author
|
|
Member
Modify the CI script to print the messages directly. |
Member
|
conflicts and CI failing. |
gavofyork
added
A7-looksgoodcantmerge
and removed
A0-please_review
This reverts commit 9c19763.
tomaka
suggested changes
Jan 14, 2020
| NetworkService<TBl, TNetSpec, TBl::Hash>, TExPool, TOc> | ||
| where | ||
| TBl: BlockT, | ||
| TBl: BlockT + Unpin, |
| } | ||
|
|
||
| impl<TBl, TCl, TSc, TNetStatus, TNet, TTxPool, TOc> Future for | ||
| impl<TBl: Unpin, TCl, TSc: Unpin, TNetStatus, TNet, TTxPool, TOc> Future for |
Contributor
There was a problem hiding this comment.
Suggested change
| impl<TBl: Unpin, TCl, TSc: Unpin, TNetStatus, TNet, TTxPool, TOc> Future for | |
| impl<TBl, TCl, TSc, TNetStatus, TNet, TTxPool, TOc> Future for |
| TExec: 'static + sc_client::CallExecutor<TBl> + Send + Sync + Clone, | ||
| TRtApi: 'static + Send + Sync, | ||
| TSc: sp_consensus::SelectChain<TBl> + 'static + Clone + Send, | ||
| TSc: sp_consensus::SelectChain<TBl> + 'static + Clone + Send + Unpin, |
Contributor
There was a problem hiding this comment.
Suggested change
| TSc: sp_consensus::SelectChain<TBl> + 'static + Clone + Send + Unpin, | |
| TSc: sp_consensus::SelectChain<TBl> + 'static + Clone + Send, |
|
|
||
| while let Ok(Async::Ready(Some(task_to_spawn))) = self.to_spawn_rx.poll() { | ||
| while let Poll::Ready(Some(task_to_spawn)) = Pin::new(&mut this.to_spawn_rx).poll_next(cx) { | ||
| // TODO: Update to tokio 0.2 when libp2p get switched to std futures (#4383) |
Contributor
There was a problem hiding this comment.
Libp2p has been switched to std futures.
Contributor
|
When you push 17 more commits after a previous review, I'd suggest to ask for a new review instead of just merging. |
This was referenced Jan 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3099.