This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
bkchr
reviewed
Dec 24, 2019
.gitlab-ci.yml
Outdated
| <<: *build-binary | ||
| script: | ||
| - ./.maintain/node-template-release.sh ./artifacts/substrate/substrate-node-template.tar.gz | ||
| - cp -r .maintain/docker/substrate.Dockerfile ./artifacts/substrate/ |
Member
There was a problem hiding this comment.
Why do we do this here? And not in the build substrate job above?
Contributor
Author
There was a problem hiding this comment.
you're right, right now it's not effective to split these jobs
Contributor
Author
There was a problem hiding this comment.
actually, we are compiling it right there: https://gitlab.parity.io/parity/substrate/-/jobs/339822#L706 , during cargo build.
Can we use that artifact?
Member
There was a problem hiding this comment.
I was speaking about the docker file. Putting the node template into its own job sounds reasonable.
stanislav-tkach
approved these changes
Dec 25, 2019
bkchr
approved these changes
Dec 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
&nameis called "the yaml anchor", and used to reduce dupes, like that: