This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
rphmeier
added
the
A3-in_progress
rphmeier
added
A0-please_review
rphmeier
added
A0-please_review
gnunicorn
approved these changes
Aug 6, 2018
Contributor
gnunicorn
left a comment
gnunicorn
left a comment
There was a problem hiding this comment.
Some minor style/wrapping thingies (which I wouldn't have to state if we used a tool like ...you know... rustfmt ;p )
| self.inner.produced_statements.availability = | ||
| statements.extrinsic = Some(extrinsic); | ||
| statements.availability = | ||
| Some(GenericStatement::Available(hash)); |
| where | ||
| A: LocalPolkadotApi + Send + Sync + 'static, | ||
| C: BlockchainEvents<Block> + ChainHead<Block> + bft::BlockImport<Block> + bft::Authorities<Block> + Send + Sync + 'static, | ||
| C: BlockchainEvents<Block> + ChainHead<Block> + BlockBody<Block> + bft::BlockImport<Block> + bft::Authorities<Block> + Send + Sync + 'static, |
dvdplm
reviewed
Aug 6, 2018
| log = "0.3" | ||
| substrate-codec = { path = "../../substrate/codec" } | ||
| substrate-primitives = { path = "../../substrate/primitives" } | ||
| kvdb = { git = "https://github.com/paritytech/parity.git" } |
Contributor
There was a problem hiding this comment.
The kvdb* crates are in parity-common now.
| fn extract_io_err(err: ::kvdb::Error) -> io::Error { | ||
| match err { | ||
| ::kvdb::Error(::kvdb::ErrorKind::Io(io_err), _) => io_err, | ||
| ::kvdb::Error(::kvdb::ErrorKind::Msg(msg), _) => io::Error::new( |
Contributor
There was a problem hiding this comment.
These errors are gone and replaced (in parity-ethereum) by plain io::Error. PR
| pub fn new(config: Config) -> io::Result<Self> { | ||
| let mut db_config = DatabaseConfig::with_columns(Some(columns::NUM_COLUMNS)); | ||
| db_config.memory_budget = config.cache_size; | ||
| db_config.wal = true; |
Contributor
There was a problem hiding this comment.
This option is also gone (always true now).
dvdplm
reviewed
Aug 6, 2018
| } | ||
|
|
||
| /// Make some data available provisionally. | ||
| pub fn make_available(&self, data: Data) -> io::Result<()> { |
Contributor
There was a problem hiding this comment.
What's wrong with fetch or get?
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
Also fix the weird file structure by making `wasm_executor.rs` -> `wasm_executor/mod.rs`.
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Add renominate * Add tests for renominate * Build wasm * Add renominate in fee * Nit
liuchengxu
pushed a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
…branch Switch to upstream merkle tree library revision
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* scripts: Generate changelog Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * scripts: Remove git tag verification Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * scripts: Add usage example Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Update releasing steps to automate the changelog commits Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #371
Introduces an availability store. Validators who are meant to guarantee available data will not cast votes until the data has been written to disk. Currently it resides in a fixed subdirectory of the general data directory, but we will make it configurable in the future.
Block data network requests are now answered from the store if not kept in memory already.
There is no protocol for discovering peer IDs for validators who have historic data available (yet).