This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Society: Ensure all votes are removed after tally#4666
Merged
gavofyork merged 2 commits intoparitytech:masterfrom Jan 17, 2020
Merged
Society: Ensure all votes are removed after tally#4666gavofyork merged 2 commits intoparitytech:masterfrom
gavofyork merged 2 commits intoparitytech:masterfrom
Conversation
andresilva
reviewed
Jan 17, 2020
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
changes lgtm but I'm not familiar with this module. would appreciate another review.
andresilva
reviewed
Jan 17, 2020
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
maybe add a test for the case where a voter is removed while the tally is open? (don't know how easy that is)
gavofyork
approved these changes
Jan 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a fringe scenario where a member might be asynchronously removed from the membership pool before a vote is tallied. (i.e. through the Defender lifecycle).
In this case, the votes that this user may have stored will not be cleaned up during the rotation cycles.
In addition to
takewhile iterating over members to calculate votes, we also callremove_allon the vote storage items to really make sure all votes are gone after we have finished tallying.This fixes the behavior for both
VotesandDefenderVotes.