This repository was archived by the owner on Nov 15, 2023. It is now read-only.
client/finality-grandpa/communication: Add doc comment for PeerReport#4684
Merged
gavofyork merged 1 commit intoparitytech:masterfrom Jan 20, 2020
Merged
client/finality-grandpa/communication: Add doc comment for PeerReport#4684gavofyork merged 1 commit intoparitytech:masterfrom
gavofyork merged 1 commit intoparitytech:masterfrom
Conversation
andresilva
approved these changes
Jan 20, 2020
Contributor
I won't push for it, but I have a preference for documenting all public items because the auto-generated docs look better and it's a good habit to keep. |
rphmeier
added
A8-looksgood
and removed
A0-please_review
rphmeier
approved these changes
Jan 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying review suggestion from https://github.com/paritytech/substrate/pull/4661/files#r368046058.
@rphmeier I think the members of the struct are self-explanatory. Let me know if you still want them documented.