This repository was archived by the owner on Nov 15, 2023. It is now read-only.
use write_all instead of write#488
Merged
gavofyork merged 1 commit intoparitytech:masterfrom Aug 3, 2018
icodezjb:patch-1
Merged
use write_all instead of write#488gavofyork merged 1 commit intoparitytech:masterfrom icodezjb:patch-1
gavofyork merged 1 commit intoparitytech:masterfrom
icodezjb:patch-1
Conversation
io::Write::write is not guaranteed to process the entire buffer. it return how many bytes were processed, which might be smaller than a given buffer’s length. use write_all instead.
|
It looks like @icodezjb hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla-polkadot.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
tomusdrw
approved these changes
Aug 3, 2018
Contributor
Author
|
clabot:check |
Contributor
Author
|
[clabot:check] |
|
It looks like @icodezjb signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
dvdplm
added a commit
that referenced
this pull request
Aug 5, 2018
* master: Add Links to Tags and House Style (#413) Add seed generation tests (#476) Added commit hash to --version (#489) use write_all instead of write (#488) should be MAX_IMPORTING_BLOCKS (#486) Use hex_literal in tests, use rustc-hex from crates (#481) Lower bft timeout (#483) force BFT delay in consensus service, not in proposer logic (#477)
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
Closed
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
liuchengxu
pushed a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
General improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io::Write::write is not guaranteed to process the entire buffer. it return how many bytes were processed, which might be smaller than a given buffer’s length. use write_all instead.