Fix various spelling errors by shawntabrizi · Pull Request #4940 · paritytech/substrate

shawntabrizi · 2020-02-15T17:54:00Z

Closes: #4933

I used https://github.com/streetsidesoftware/cspell

with the following configuration:

// cSpell Settings
{
	// Version of the setting file.  Always 0.1
	"version": "0.1",
	// language - current active spelling language
	"language": "en",
	// words - list of words to be always considered correct
	"words": [
		"serde",
		"dispatchable",
		"perbill",
		"hasher",
		"unbonding",
		"unbond",
		"rebond",
		"unbonded",
		"stakers",
		"validator",
		"validator's",
		"staker",
		"phragmen",
		"uvec",
		"prefs",
		"unstake",
		"misbehaviors",
		"slashable",
		"uint",
		"invulnerables",
		"npos",
		"mutables",
		"unlookup",
		"twox",
		"gavofyork",
		"consts",
		"overslash",
		"incentivizes",
		"structfield",
		"powf",
		"inpos",
		"unstaked",
		"testnets",
		"doesnt",
		"sesh",
		"referencer",
		"overslashing",
		"subtrait",
		"bitor",
		"unreserving",
		"staking's",
		"suspendable",
		"preimage",
		"undelegate",
		"cooloff",
		"proxying",
		"preimages",
		"undelegated",
		"thresholding",
		"undelegation",
		"supermajority",
		"enumflags",
		"concat",
		"passthrough",
		"wasm",
		"disincentivize",
		"permissionless",
		"decodable",
		"permill",
		"dispatchable",
		"deserializer",
		"serializer",
		"leaderboard",
		"whatevs",
		"wabt",
		"pwasm",
		"entrypoints",
		"funcref",
		"deserialized",
		"reserialized",
		"BACKTRACE",
		"entrypoint",
		"unhashed",
		"serializable",
		"newtype",
		"offchain",
		"imonline",
		"pubkey",
		"heartbeat",
		"inherents",
		"runtimes",
		"unvested",
		"utilisuba",
		"modlpy",
		"sigs",
		"timepoint",
		"multisigs",
		"keypair",
		"stateful",
		"suba",
		"multisig",
		"Pseudonymal",
		"prng",
		"wasmi",
		"camelcase",
		"extrinsics",
		"nocompile",
		"runtime's",
		"handleable",
		"totokens",
		"idents",
		"parens",
		"bitmask",
		"hashable",
		"appendable",
		"uncheckedextrinsic",
		"structs",
		"debuggable",
		"scrate",
		"impls",
		"LINKEDMAPU",
		"PUBGETLINKEDMAPU",
		"COMPLEXTYPE",
		"unstaking",
		"trybuild",
		"WITHCONFIG",
		"PUBU",
		"testextension",
		"dispatchables",
		"enum's",
		"partialeq",
		"Weighable",
		"hiddencrate",
		"whitespaces",
		"hiddencrate",
		"claused",
		"getfn",
		"sline",
		"tokenstream",
		"WITHCONFIGMYDEF",
		"PUBMAPU",
		"PUBGETMAPU",
		"MAPU",
		"GETMAPU",
		"GETLINKEDMAPU",
		"PUBLINKEDMAPU",
		"pubmap",
		"mydef",
		"extragenesis",
		"paren",
		"coldot",
		"untrusted",
		"dser",
		"hashers",
		"prepended",
		"traitinstance",
		"GETU",
		"PUBGETU",
		"WITHCONFIGMYDEFOPT",
		"btree",
		"subtrie",
		"unmarshall",
		"enaction",
		"preload",
		"Computor",
		"rustc",
		"recurse",
		"bytecode",
		"parameterizations",
		"accountid",
		"instantiator",
		"toks",
		"sandboxing",
		"codehash",
		"reinstrument",
		"memorywise",
		"sandboxed",
		"unmarshalling",
		"reinstrumentation",
		"anyfunc",
		"forgetit",
		"subaccounts",
		"judgements",
		"Keccak",
		"memoized",
		"blocknumber",
		"revoting",
		"inspectable",
		"sudid",
		"sudoer",
		"unvouch",
		"unfound",
		"unbidding",
		"rewardees",
		"underflowed",
		"Applyable",
		"attackable",
		"bvalue",
		"precompile",
		"precompiles",
		"ethereum",
		"gameability",
		"panickers",
		"myname",
		"Dapps",
		"merkle",
		"blockchain",
		"DEDUP",
		"Unrequested",
		"subaccount",
		"headshot",
		"doctests",
		"backticks",
		"snapshotted",
		"reproposing",
		"rposition",
		"Rustdocs",
		"rustdoc",
		"data's",
		"struct's",
		"endianness",
		"encodable",
		"retv",
		"coinbase",
		"nonfull",
		"Unscored",
		"vals",
		"chacha",
		"incentivized",
		"Malloc",
		"keystore",
		"seedable",
		"blockchains",
		"unfounding",
		"unvouched",
		"extrinsic's",
		"tx's",
		"turbofish",
		"biguint",
		"lpad",
		"webassembly",
		"there'll",
		"polkadot",
		"memtrie",
		"unpopulate",
		"memdb",
		"keyspace",
		"txpool",
		"genericity",
		"standardmap",
		"uniqueid",
		"Schnorrkel",
		"preaudit",
		"descendents",
		"unappliable",
		"perquintill",
		"lstrip",
		"rhat",
		"qhat",
		"honggfuzz",
		"biguints",
		"unergonomic",
		"HFUZZ",
		"vecs",
		"suri",
		"Ristretto",
		"Schnorr",
		"Multiaddr",
		"hexdisplay",
		"deser",
		"rustversion",
		"footgun",
		"Inflector",
		"Uninit",
		"ecdsa",
		"destructured",
		"parachain",
		"superset",
		"Ferdie",
		"dealloc",
		"nanos",
		"secp",
		"alloc",
		"libsecp",
		"finalnum",
		"deserialization",
		"byteorder",
		"dalek",
		"HDKD",
		"zeroize",
		"hmac",
		"microcontrollers",
		"rngs",
		"Cosignature",
		"fuzzer",
		"musig",
		"bigint",
		"wasi",
		"propagations",
		"UUID",
		"backends",
		"testchild",
		"childtrie",
		"childchange",
		"schnorrkel's",
		"impl'd",
		"impl'ing",
		"castable",
		"exts",
		"RPCs",
		"repr",
		"strat",
		"ptrs",
		"supertraits",
		"deallocation",
		"dogglesworth",
		"std's",
		"deque",
		"keyspaced",
		"semver",
		"bytesref",
		"drilldown",
		"externval",
		"funcs",
		"deserializable",
		"Unserializable",
		"Serializers",
		"testval",
		"timespan",
		"heappages",
		"memref",
		"endians",
		"bytewise",
		"testinh",
		"downcasting",
		"mainnet",
		"libc",
		"Unallowed",
		"subkey",
		"mkdir",
		"wasmtime",
		"bindgen",
		"rocksdb",
		"structopt",
		"tempfile",
		"multiaddress",
		"MILLISECS",
		"bootnodes",
		"testnet",
		"unlicense",
		"bootnode",
		"subcommand",
		"chainspec",
		"subcommand",
		"toolchain",
		"rustup",
		"vergen",
		"auths",
		"hardcoded",
		"deduplication",
		"dref",
		"asciish",
		"autocfg",
		"memmap",
		"getrandom",
		"bitvec",
		"arrayvec",
		"winapi",
		"pnames",
		"ptypes",
		"pborrow",
		"threadsafe",
		"auraslot",
		"babeslot",
		"dword",
		"plugable",
		"struct",
		"destinated",
		"substream",
		"mitigations",
		"RUSTFLAGS",
		"OPENSSL",
		"USERPROFILE",
		"LLVM",
		"vcpkg",
		"libssl",
		"libclang",
		"cmake",
		"cryptocurrency",
		"roadmap",
		"Pessimization",
		"mychain",
		"codeowner",
		"breaksapi",
		"pleasereview",
		"blockchain's",
		"symlink",
		"buildtools",
		"adoc",
		"breaksconsensus",
		"openish",
		"customizability",
		"PBFT",
		"DDOS",
		"noncanonical",
		"canonicalization",
		"canonicality",
		"uncanonicalized",
		"uncanonicalize",
		"canonicalized",
		"canonicalize",
		"canonicalizes",
		"memorydb",
		"kvdb",
		"forkable",
		"unqueue",
		"oneshot",
		"rebalance",
		"unimported",
		"finalizer",
		"testsuite",
		"BACKOFF",
		"rebalance",
		"rebalancing",
		"precommit",
		"prevote",
		"precommits",
		"prevoted",
		"unfinalized",
		"resetted",
		"invalidators",
		"heapsize",
		"onchain",
		"prevotes",
		"precommitted",
		"cors",
		"bitflags",
		"rtype",
		"Grafana",
		"SIGTERM",
		"SIGTERM",
		"SIGINT",
		"peerset",
		"quickcheck",
		"peerset",
		"proto",
		"protos",
		"strs",
		"cmds",
		"mdns",
		"protobuf",
		"preruntime",
		"checked",
		"compat",
		"yamux",
		"subcommands",
		"tempdir",
		"Kademlia",
		"flattenable",
		"peersstate",
		"threadpool",
		"nfin",
		"unpruned",
		"Unroutable",
		"smallvec",
		"curr",
		"errno",
		"ctrie",
		"rpassword",
		"isatty",
		"inout",
		"CHTs",
		"ucht",
		"lmap",
		"kinded",
		"fdlimit",
		"journaled",
		"deregistered",
		"unregisters",
		"uninserted",
		"interruptible",
		"errored",
		"reenable",
		"syscalls",
		"syscall",
		"klen",
		"inmem",
		"dbtx",
		"UNDECODABLE",
		"canonicalizations",
		"prunings",
		"libp",
		"reput",
		"repropagated",
		"repropagate",
		"Muxer",
		"pset",
		"nohash",
		"addrs",
		"numer",
		"kbytes",
		"prost",
		"Kademlia's",
		"Tokio's",
		"uncategorized",
		"mysecret",
		"Notif",
		"mplex",
		"boneh",
		"unapply",
		"comms",
		"repropagation",
		"disp",
		"fprb",
		"cpus",
		"trie's",
		"orgs",
		"abcdefg",
		"txqueue",
		"txcount",
		"fchr",
		"unwatch",
		"unsecure",
		"sysinfo",
		"rustls",
		"sync'ed",
		"connect'em",
		"oneof",
		"foobarbaz",
		"secio",
		"repu",
		"upgr",
		"deps",
		"kbuckets",
		"Bloaty",
		"blocknum",
		"QWERTYUIOPASDFGHJKLZXCVBNM",
		"MILLICENTS",
		"nocapture",
		"feemul",
		""
	],
	"ignoreWords": [
		"initialise",
		"finalise",
		"srml",
		"overlayed",
		"malus",
		"Kianenigma",
		"Amar",
		"joepetrowski",
		"bkchr",
		"Dothereum",
		"kulupu",
		"kusama",
		"edgeware",
		"substratee",
		"paritytech",
		"Emberic",
		"Danta",
		"pepyakin",
		"tomusdrw",
		"andresilva",
		"demi",
		"mxinden",
		"thiolliere",
		"sorpaas",
		"Robbepop",
		"Behaviour",
		"Behaviour's",
		"misbehaviour",
		"Millo",
		"Finalised",
		"UTXO",
		""
	],
	// flagWords - list of words to be always considered incorrect
	// This is useful for offensive words and common spelling errors.
	// For example "hte" should be "the"
	"flagWords": [
		"hte"
	],
	"allowCompoundWords": true
}

One word that we should still possibly fix is usage of Behaviour, but is shows up in a lot of places and some libraries.

client/finality-grandpa/src/tests.rs

kianenigma · 2020-02-15T19:24:38Z

Might consider also to add this to CI.

+1

(I am horrible at writing. Having a strict linter for this just makes my life easier. I already use this plugin locally but have to make modifications.)

bin/node/cli/tests/common.rs

client/api/src/execution_extensions.rs

client/cli/src/params.rs

client/executor/common/src/sandbox.rs

frame/support/src/weights.rs

primitives/blockchain/src/lib.rs

joepetrowski · 2020-02-15T21:34:11Z

primitives/core/src/ed25519.rs

 	/// Make a new key pair from secret seed material.
 	///
-	/// You should never need to use this; generate(), generate_with_phrasee
+	/// You should never need to use this; generate(), generate_with_phrase


This comment could be more clear in general (although maybe not directly related to this PR). Is this saying I should use generate_with_phrase instead?

primitives/core/src/offchain/mod.rs

primitives/io/src/lib.rs

Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

client/api/src/execution_extensions.rs

…ling

pepyakin · 2020-02-17T13:46:10Z

The CI failure is related to #4944

* meaningfull -> meaningful * initialise -> initialize * tokans -> tokens * incentivise -> incentivize * lenght -> length * incentivisation -> incentivization * doesnt't -> doesn't * overwriten -> overwritten * lifecycle -> life cycle * lifecycle -> life cycle * usefull -> useful * noone -> no one * spaming -> spamming * defered -> deferred * hieght -> height * sumation -> summation * ingore -> ignore * registed -> registered * Auxialary -> Auxiliary * loggin -> logging * independance -> independence * trailling -> trailing * responsability -> responsibility * trunkated -> truncated * Weither -> Whether * informations -> information * Runtume -> Runtime * choosen -> chosen * delcataion -> declaration * Unchekced -> Unchecked * defintion -> definition * scrach -> scratch * imput -> input * transfered -> transferred * endownment -> endowment * Determinator -> Determiner * relevent -> relevant * emited -> emitted * acocunt -> account * proprotional -> proportional * instantiaion -> instantiation * commited -> committed * tombstonedead -> tombstone * uwnrap -> unwrap * acount -> account * specialised -> specialized * existant -> existent * requried -> required * Anull -> Annul * AUTHORITES -> AUTHORITIES * underyling -> underlying * recognisable -> recognizable * Capitalise -> Capitalize * reportfor -> report for * hearbeat -> heartbeat * onlineness -> being online * creater -> creator * Bytearray -> Byte array * Despoit -> Deposit * substratced -> subtracted * Curent -> Current * imbalanes -> imbalances * countfown -> countdown * inexisting -> inexistent * additionaly -> additionally * substracted -> subtracted * auxilary -> auxiliary * parital -> partial * in't -> isn't * compatability -> compatibility * infomation -> information * etected -> detected * extrinsiscs -> extrinsics * reprensentation -> representation * coonfiguration -> configuration * primtives -> primitives * miscelanious -> miscellaneous * VERISON -> VERSION * endcoded -> encoded * Genrates -> Generates * miliseconds -> milliseconds * occured -> occurred * trully -> truely * truely -> truly * conjuction -> conjunction * encouters -> encounters * customised -> customized * deterministicly -> deterministically * finalisation -> finalization * pluggable -> plugable * wakeup -> wake-up * interemdiate -> intermediate * intepreting -> interpreting * finalzied -> finalized * throgh -> through * extinsic -> extrinsic * convient -> convenient * allocater -> allocator * propagateable -> propagatable * succesfuly -> successfully * finalising -> finalizing * publically -> publicly * phrasee -> phrase * substration -> substractions * substractions -> subtractions * neccessarily -> necessarily * Inlucde -> Include * unefficient -> inefficient * thay -> they * funtion -> function * datastructures -> data structures * infromation -> information * propagatable -> propagable * ecountered -> encountered * recognise -> recognize * intergration -> integration * lastet -> latest * datatypes -> data types * datatype -> data type * Strongarming -> Strong Arming * avaible -> available * Commiting -> Committing * Retreiving -> Retrieving * shoud -> should * canonicaliziation -> canonicalization * comitted -> committed * clonable -> cloneable * Uknown -> Unknown * reponse -> response * arbitary -> arbitrary * Capapbilities -> Capabilities * responsbile -> responsible * initialisation -> initialization * cames -> came * intemediate -> intermediate * reqeust -> request * intance -> instance * explcitly -> explicitly * neighor -> neighbor * reolving -> resolving * untill -> until * Validte -> Validate * deserailize -> deserialize * literaly -> literally * preceeding -> preceding * abpve -> above * chcecked -> checked * numbet -> number * Unknow -> Unknown * halfs -> halves * gossup -> gossip * givent -> given * immediatelly -> immediately * slicable -> sliceable * conensus -> consensus * Mimicks -> Mimics * acccept -> accept * serialise -> serialize * exstrinsics -> extrinsics * panicks -> panics * maintaince -> maintenance * repeatidely -> repeatedly * anecstor -> ancestor * becasue -> because * processer -> processor * Prunning -> Pruning * insterested -> interested * unuseful -> not useful * yeided -> yielded * descendfing -> descending * corresponts -> corresponds * survivew -> survive * keps -> keeps * ligh -> light * prerequisities -> prerequisites * positiion -> position * depedency -> dependency * extrinisic -> extrinsic * atomicaly -> atomically * staticly -> statically * resul -> result * timestamb -> timestamp * Utilites -> Utilities * ammount -> amount * pocess -> process * exteral -> external * Update client/finality-grandpa/src/tests.rs * Update primitives/io/src/lib.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update primitives/blockchain/src/lib.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update frame/support/src/weights.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update bin/node/cli/tests/common.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update client/api/src/execution_extensions.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update client/cli/src/params.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update client/executor/common/src/sandbox.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update client/api/src/execution_extensions.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update client/finality-grandpa/src/communication/mod.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update client/state-db/src/pruning.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update frame/contracts/src/tests.rs Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update client/api/src/execution_extensions.rs * bump impl * timestamb -> timestamp Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

shawntabrizi added 30 commits February 15, 2020 14:35

meaningfull -> meaningful

f3cffea

initialise -> initialize

8d8f394

tokans -> tokens

c11054a

incentivise -> incentivize

55987bb

lenght -> length

8b5abdb

incentivisation -> incentivization

3e612d7

doesnt't -> doesn't

d39fc65

overwriten -> overwritten

ececdee

lifecycle -> life cycle

9a4baf5

lifecycle -> life cycle

70bdd9d

usefull -> useful

8648c15

noone -> no one

357b77e

spaming -> spamming

e12d26a

defered -> deferred

723e551

hieght -> height

75be5ad

sumation -> summation

49d5c46

ingore -> ignore

cdaaa3c

registed -> registered

d1dd5ce

Auxialary -> Auxiliary

d33db79

loggin -> logging

a4f2889

independance -> independence

197fdca

trailling -> trailing

b7e12a0

responsability -> responsibility

f9a60a8

trunkated -> truncated

f1e70d1

Weither -> Whether

71e7ae4

informations -> information

068b1bc

Runtume -> Runtime

363dc19

choosen -> chosen

f09aec3

delcataion -> declaration

0e4e546

Unchekced -> Unchecked

2f34b1b

shawntabrizi commented Feb 15, 2020

View reviewed changes

client/finality-grandpa/src/tests.rs Outdated Show resolved Hide resolved

Update client/finality-grandpa/src/tests.rs

fdee855

bkchr approved these changes Feb 15, 2020

View reviewed changes

tomusdrw approved these changes Feb 15, 2020

View reviewed changes

joepetrowski reviewed Feb 15, 2020

View reviewed changes

shawntabrizi and others added 11 commits February 16, 2020 00:01

Update primitives/io/src/lib.rs

a59d926

Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Update primitives/blockchain/src/lib.rs

eece550

Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Update frame/support/src/weights.rs

632be0b

Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Update bin/node/cli/tests/common.rs

fcb3cec

Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Update client/api/src/execution_extensions.rs

fcf26d1

Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Update client/cli/src/params.rs

ad1d851

Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Update client/executor/common/src/sandbox.rs

49a1512

Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Update client/api/src/execution_extensions.rs

95a0f26

Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Update client/finality-grandpa/src/communication/mod.rs

f0cc1ec

Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Update client/state-db/src/pruning.rs

2fc2704

Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Update frame/contracts/src/tests.rs

25c7499

Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

shawntabrizi commented Feb 15, 2020

View reviewed changes

client/api/src/execution_extensions.rs Outdated Show resolved Hide resolved

shawntabrizi commented Feb 15, 2020

View reviewed changes

client/api/src/execution_extensions.rs Outdated Show resolved Hide resolved

shawntabrizi added 2 commits February 16, 2020 00:58

Update client/api/src/execution_extensions.rs

4f756f5

bump impl

3817bd7

pepyakin approved these changes Feb 17, 2020

View reviewed changes

shawntabrizi added 2 commits February 17, 2020 14:02

Merge remote-tracking branch 'upstream/master' into shawntabrizi-spel…

2f55568

…ling

timestamb -> timestamp

64540b0

shawntabrizi merged commit db1ab7d into paritytech:master Feb 17, 2020

shawntabrizi deleted the shawntabrizi-spelling branch February 17, 2020 14:07

shawntabrizi mentioned this pull request Mar 16, 2021

Migrate pallet-proxy to pallet attribute macro #8365

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix various spelling errors#4940

Fix various spelling errors#4940
shawntabrizi merged 202 commits intoparitytech:masterfrom
shawntabrizi:shawntabrizi-spelling

shawntabrizi commented Feb 15, 2020 •

edited

Loading

Uh oh!

Uh oh!

kianenigma commented Feb 15, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joepetrowski Feb 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pepyakin commented Feb 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

shawntabrizi commented Feb 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kianenigma commented Feb 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joepetrowski Feb 15, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pepyakin commented Feb 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shawntabrizi commented Feb 15, 2020 •

edited

Loading

kianenigma commented Feb 15, 2020 •

edited

Loading