This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix substrate default storage location#5064
Merged
gnunicorn merged 1 commit intoparitytech:masterfrom Mar 4, 2020
Merged
Conversation
Contributor
Author
|
I see #5059 has been merged. Let me rebase so the change set is a little smaller/cleaner. |
chevdor
force-pushed
the
wk-docker-cleanup
branch
from
cba7560 to
0d66d5e
Compare
Contributor
Author
|
Done, now the changes brought by #5059 are no longer part of this PR. |
chevdor
force-pushed
the
wk-docker-cleanup
branch
from
0d66d5e to
5d3eb8b
Compare
kianenigma
approved these changes
Feb 26, 2020
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Looks good! I have been using this lately and will give it more tries.
kianenigma
added
A8-looksgood
B0-silent
Contributor
Author
|
I don't think the failing test is coming from the PR. Can we manually trigger a re-run of the tests? |
bkchr
approved these changes
Feb 27, 2020
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 4, 2020
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following:
So this PR means we no longer have to provide the
-d /datato substrate to make the volume mounting works.