Increase node template max block weight#5171
Conversation
|
It looks like @JoshOrndorff signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
kianenigma
left a comment
There was a problem hiding this comment.
A mystery that I haven't solved is why this just became a problem when none of those weight have changed in 9 months since #3157
I think the weights were one average lower in my old initial PR and this was okay. Transfer was probably 10_000 or sth.
|
Just want to double check on my question before I merge.
Initially I was thinking it did need one, but I'm thinking the node template runtime should always stay at version 1 and when individual projects start building from the template, then they can start bumping the version. |
@JoshOrndorff AFAIK you are correct here and there is no need to pump the version. |
This PR increases the node template's maximum block weight from 1 million (
1_000_000) to 1 billion (1_000_000_000) to match the main Substrate node. The former lower weight is the exact weight of a balance transfer which means that after a timestamp is in the block there isn't enough room left for even a single balance transfer.A mystery that I haven't solved is why this just became a problem when none of those weight have changed in 9 months since #3157
Cross reference: https://github.com/substrate-developer-hub/substrate-node-template/pull/25
Dumb question: Does this require a spec version bump? I think it does.