Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Increase node template max block weight#5171

Merged
gavofyork merged 1 commit intomasterfrom
joshy-template-weight
Mar 6, 2020
Merged

Increase node template max block weight#5171
gavofyork merged 1 commit intomasterfrom
joshy-template-weight

Conversation

@JoshOrndorff
Copy link
Contributor

@JoshOrndorff JoshOrndorff commented Mar 6, 2020

This PR increases the node template's maximum block weight from 1 million (1_000_000) to 1 billion (1_000_000_000) to match the main Substrate node. The former lower weight is the exact weight of a balance transfer which means that after a timestamp is in the block there isn't enough room left for even a single balance transfer.

A mystery that I haven't solved is why this just became a problem when none of those weight have changed in 9 months since #3157

Cross reference: https://github.com/substrate-developer-hub/substrate-node-template/pull/25

Dumb question: Does this require a spec version bump? I think it does.

@parity-cla-bot
Copy link

It looks like @JoshOrndorff signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@JoshOrndorff JoshOrndorff requested a review from kianenigma March 6, 2020 15:08
@bkchr bkchr added A8-looksgood B0-silent Changes should not be mentioned in any release notes labels Mar 6, 2020
@bkchr bkchr added this to the 2.0 milestone Mar 6, 2020
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mystery that I haven't solved is why this just became a problem when none of those weight have changed in 9 months since #3157

I think the weights were one average lower in my old initial PR and this was okay. Transfer was probably 10_000 or sth.

@JoshOrndorff
Copy link
Contributor Author

Just want to double check on my question before I merge.

Does this require a spec_version bump?

Initially I was thinking it did need one, but I'm thinking the node template runtime should always stay at version 1 and when individual projects start building from the template, then they can start bumping the version.

@riusricardo
Copy link
Contributor

Initially I was thinking it did need one, but I'm thinking the node template runtime should always stay at version 1 and when individual projects start building from the template, then they can start bumping the version.

@JoshOrndorff AFAIK you are correct here and there is no need to pump the version.

@gavofyork gavofyork merged commit 638be17 into master Mar 6, 2020
@gavofyork gavofyork deleted the joshy-template-weight branch March 6, 2020 17:32
General-Beck pushed a commit to General-Beck/substrate that referenced this pull request Mar 7, 2020
General-Beck pushed a commit to General-Beck/substrate that referenced this pull request Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

B0-silent Changes should not be mentioned in any release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants