This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
…ble-equialize-offchain-2
…ch/substrate into kiz-enable-equialize-offchain-2
kianenigma
requested review from
Demi-Marie,
andresilva,
gui1117,
pepyakin and
sorpaas
as code owners
Contributor
|
why does it includes #5686 ? |
Contributor
Author
|
pushed by mistake. I will revert. |
This reverts commit dbdd27f.
kianenigma
commented
Apr 20, 2020
bkchr
reviewed
Apr 21, 2020
bin/node/runtime/src/lib.rs
Outdated
| type ElectionLookahead = ElectionLookahead; | ||
| type Call = Call; | ||
| type SubmitTransaction = TransactionSubmitterOf<()>; | ||
| type Randomness = RandomnessCollectiveFlip; |
Contributor
Author
There was a problem hiding this comment.
Ow I didn't know Babe also implements it. What are the differences? I don't think the randomness that Staking needs is in any sense consensus critical.
Member
There was a problem hiding this comment.
Babe provides "real" randomness, while the one provided by collective flip is based on the last 80? block hashes.
Member
There was a problem hiding this comment.
isn't there a local (non-deterministic) rand() function for offchain workers?
Contributor
Author
There was a problem hiding this comment.
I'll switch to that then 👍
gavofyork
approved these changes
Apr 24, 2020
gavofyork
added
A8-mergeoncegreen
and removed
A0-please_review
Member
|
Needs a companion PR. |
…ble-equialize-offchain-2
kianenigma
removed request for
Demi-Marie,
NikVolf,
andresilva,
gui1117,
pepyakin and
sorpaas
Member
|
bot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following: #5452
Just enables to offchain worker code that submits the solution back to run a random number of iterations (capped by
type MaxIterations). Rest of the changes pertain to fuzzing and testing.polkadot companion: paritytech/polkadot#1039