This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
arkpar
reviewed
Apr 29, 2020
bin/node/bench/src/tempdb.rs
Outdated
| DatabaseType::ParityDb => { | ||
| Arc::new(ParityDbWrapper( | ||
| parity_db::Db::open( | ||
| &parity_db::Options::with_columns(self.0.path(), 1) |
Member
There was a problem hiding this comment.
Would be best to replicate these settings here:
https://github.com/paritytech/substrate/blob/master/client/db/src/parity_db.rs#L37-L42
Contributor
Author
There was a problem hiding this comment.
with those settings getting this error message, probably on reopen copied files
2020-04-29 17:05:30 Starting Trie read benchmark(empty database (200 keys), db_type: ParityDb)
2020-04-29 17:05:30 Started reindex for index 00_16
2020-04-29 17:05:30 Started reindex for index 00_17
2020-04-29 17:05:30 Eror replaying log: Corruption("Missing table"). Reverting
thread 'main' panicked at 'Failed to get key: db error: "Trie lookup error: Invalid state root: 0x978a92e555f0b502acfd735de980638138c37bbff2e3dfa66e7fe53384d3d541"', bin/node/bench/src/trie.rs:187:25
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Member
There was a problem hiding this comment.
This is caused by lots of collisions that come from prefixed keys. So either prefixes should be stripped (as in #5769) or uniform option should not be used
arkpar
approved these changes
Apr 29, 2020
NikVolf
added
A8-mergeoncegreen
and removed
A0-please_review
Contributor
|
bot merge |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.