This repository was archived by the owner on Nov 15, 2023. It is now read-only.
update comment of runtime/impl.rs#6297
Closed
sekisamu wants to merge 1 commit intoparitytech:masterfrom
sekisamu:master
Closed
update comment of runtime/impl.rs#6297sekisamu wants to merge 1 commit intoparitytech:masterfrom sekisamu:master
sekisamu wants to merge 1 commit intoparitytech:masterfrom
sekisamu:master
Conversation
|
It looks like @hammeWang signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
gavofyork
added
the
A2-insubstantial
kianenigma
added
I6-documentation
Contributor
|
This was reported a while ago and I have to look into it one more time. Indeed the research page of w3f and the implementation diverge a bit. Since the implementation was co-authored with someone else and was a long time ago, I prefer double checking it one more time. I am suspicious of our implementation being slightly wrong, in which case the comment is correct and the code needs fixing. related: I'll try to check it shortly, please don't merge/approve in the meantime. |
kianenigma
removed
the
I6-documentation
Contributor
|
Fixed here #6334 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
according to the code in function
convert, the formula should be: