This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
tomaka
added
A2-insubstantial
mxinden
approved these changes
Aug 20, 2020
Contributor
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Have been running this for 10 minutes. No failures.
while cargo test -p sc-network notifications_back_pressure -- --nocapture; do :; done
Contributor
Author
|
Confirmed working by @twittner as well. |
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #6766
The main hypothesis why this test was flaky is that the legacy substream fallback wasn't working.
#6826 fixes this problem, but we haven't tried un-ignoring the test so far.
I wanted to un-ignore this test as part of #6821, but we're having some trouble figuring out why the tests of #6821 are failing.
By opening this PR that simply un-ignores the test, I want to check whether #6821 introduces a regression, or if the problem is still there in the first place.