Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Remove hack around secondary connections handshakes#7246

Merged
1 commit merged intoparitytech:masterfrom
tomaka:cleanup-hack
Oct 1, 2020
Merged

Remove hack around secondary connections handshakes#7246
1 commit merged intoparitytech:masterfrom
tomaka:cleanup-hack

Conversation

@tomaka
Copy link
Contributor

@tomaka tomaka commented Oct 1, 2020 •
edited
Loading

See the comment of the removed code.

The very few nodes that still use Polkadot 0.8.10 and below look broken according to the telemetry anyway. We can drop compatibility with them.

@tomaka tomaka added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 1, 2020
@tomaka tomaka requested a review from mxinden October 1, 2020 10:43
mxinden
mxinden approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pierre from the past for the detailed comment.

@tomaka
Copy link
Contributor Author

tomaka commented Oct 1, 2020

bot merge

@ghost
Copy link

ghost commented Oct 1, 2020

Trying merge.

@ghost ghost merged commit c020f8f into paritytech:master Oct 1, 2020
@tomaka tomaka deleted the cleanup-hack branch October 1, 2020 14:33
ordian added a commit that referenced this pull request Oct 2, 2020
@ordian
Merge branch 'master' into ao-network-expose-incremental-priority-gro…
d0f0565 
…up-updates

* master:
  client/cli: Update to fdlimit 0.2.1 (#7249)
  Fix typo cranelift_wasm (#7248)
  Remove hack around secondary connections handshakes (#7246)
liuchengxu pushed a commit to liuchengxu/substrate that referenced this pull request Oct 5, 2020
@tomaka @liuchengxu
Remove hack around secondary connections handshakes (paritytech#7246)
4b065b2
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mxinden mxinden mxinden approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomaka @mxinden