This repository was archived by the owner on Nov 15, 2023. It is now read-only.
grandpa: remove runtime checks in prove_finality#7953
Merged
2 commits merged intomasterfrom Jan 26, 2021
Merged
Conversation
Remove checks that involve cross checking authorities in the runtime against what we have stored in the AuthoritySetChanges.
octol
added
A0-please_review
Contributor
|
Can you prepare a Polkadot companion PR? The |
…checks-against-authorities-in-runtime
bkchr
approved these changes
Jan 26, 2021
Contributor
|
bot merge |
|
Trying merge. |
ghost
deleted the
jon/remove-cross-checks-against-authorities-in-runtime
branch
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove checks that involve cross checking authorities in the runtime against what we have stored in
the
AuthoritySetChanges. This is based on the the review comment #7339 (comment)polkadot companion: paritytech/polkadot#2328