This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix Network trait implementation not doing what it's supposed to do#7985
Merged
1 commit merged intoparitytech:masterfrom Jan 26, 2021
Merged
Fix Network trait implementation not doing what it's supposed to do#79851 commit merged intoparitytech:masterfrom
1 commit merged intoparitytech:masterfrom
Conversation
tomaka
added
A0-please_review
romanb
approved these changes
Jan 26, 2021
mxinden
approved these changes
Jan 26, 2021
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
add_set_reservedandremove_set_reservedtrait methods are supposed to add/remove nodes from the reserved nodes, to guarantee that a substream will be opened and closed.They were mistakenly only adding/removing the peer from the list of nodes of the set. This means that
add_set_reserveddidn't guarantee that a substream was opened.Fix #7983