This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Implement syntax enforcment for Pallet<T>(_);#8095
Closed
Conversation
Member
|
Why enforce it? |
Contributor
Author
|
I thought some ppl could make typos like: And would have preferred a more precise error message than just But actually I agree it isn't really needed. I let the PR open if some ppl have strong opinion to have it, otherwise I'll close it. |
Member
|
Ahh. Could you not just allow only |
Member
|
I agree. I do not think enforcing this makes sense. |
Contributor
Author
|
ok, with the 3.0 released, I think we can wait to see if ppl get confused by syntax error and maybe improve on this like you suggested or maybe it is not needed at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up on #8091
This PR enforce the new syntax.
For now nothing is enforced on the fields of pallet.
If this PR doesn't get through before 3.0 I think we can close it.