This repository was archived by the owner on Nov 15, 2023. It is now read-only.
pallet-treasury | port to frame v2#8179
Closed
shamb0 wants to merge 2 commits intoparitytech:masterfrom
Closed
Conversation
gui1117
added
A0-please_review
gui1117
reviewed
Feb 23, 2021
| let _ = T::Currency::make_free_balance_be(&pot_account, value); | ||
| } | ||
|
|
||
| benchmarks_instance! { |
Contributor
There was a problem hiding this comment.
we should use benchmarks_instance here
frame/treasury/src/tests.rs
Outdated
| Treasury: treasury::{Module, Call, Storage, Config, Event<T>}, | ||
| #[macro_export] | ||
| macro_rules! decl_tests { | ||
| ($test:ty) => { |
Contributor
There was a problem hiding this comment.
(same there is no need to wrap in a macro)
frame/treasury/src/lib.rs
Outdated
Comment on lines
+320
to
+321
| Option<Proposal<T::AccountId, BalanceOf<T, I>>>, | ||
| ValueQuery, |
Contributor
There was a problem hiding this comment.
comparing the metadata should show these kind of error.
Suggested change
| Option<Proposal<T::AccountId, BalanceOf<T, I>>>, | |
| ValueQuery, | |
| Proposal<T::AccountId, BalanceOf<T, I>>, | |
| OptionQuery, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plz find the updated PR #8196
& ignore this.
pallet-collective | port to frame v2
related #7882
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the treasury pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the treasury pallet.