pallet-collective | port to frame v2

[shamb0]

pallet-collective | port to frame v2

related #7882

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: 
Thus any use of this pallet in construct_runtime! should be careful to update name in order 
not to break storage or to upgrade storage (moreover for instantiable pallet). 
If pallet is published, make sure to warn about this breaking change.

So users of the collective pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the collective pallet.

[gui1117]

so if master merged and a runtime migration either in the pallet or in a polkadot companion at the runtime level and it should be good

[shamb0]

so if master merged and a runtime migration either in the pallet or in a polkadot companion at the runtime level and it should be good

Thanks @thiolliere , will pick up for this week

[gnunicorn]

anyone working on this?

[gui1117]

it needs a migration code in polkadot or here. Because the old pallet prefix is different from the pallet name used in polkadot and kusama.

[shamb0]

Hello @thiolliere, will pick up run time migration part immediately.

[gui1117]

migration looks good to me, name must be changed, and genesis build is wrong

A test would be good, something like:

• apply migration
• ensure no keys are remaining at the old prefix, so we haven't miss any storages.

[gui1117]

you need to merge master because rust version in CI has changed.

But last changes are good to me

[gui1117]

can you merge master ? Once this is done I'll take a second look and it needs another approval maybe @ascjones or somebody else. Then it is good to go.

[shamb0]

Hello @thiolliere, merge to upstream master Done 👍

[shawntabrizi]

@shamb0 looks like collective got updated since this was done.

Care to update this for latest master?

If so, feel free to reopen

[gui1117]

yes need master merge, and a second review