This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
github-actions
bot
added
the
A3-in_progress
apopiak
reviewed
Feb 26, 2021
Closed
gavofyork
reviewed
Feb 26, 2021
gui1117
reviewed
Feb 26, 2021
Closed
apopiak
reviewed
Mar 1, 2021
athei
reviewed
Mar 1, 2021
gui1117
reviewed
Mar 1, 2021
Contributor
|
should we allow decl_module to implement on_idle? I think we can just make decl_module always define the default on_idle and not allow user to use its own implementation. EDIT: but now that it is implemented, we can keep it. |
gui1117
reviewed
Mar 1, 2021
gui1117
reviewed
Mar 1, 2021
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
athei
reviewed
Mar 1, 2021
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
gui1117
reviewed
Mar 1, 2021
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
gui1117
approved these changes
Mar 9, 2021
Contributor
gui1117
left a comment
gui1117
left a comment
There was a problem hiding this comment.
looks good, some doc nitpicks.
Also doc of expansion of pallet macro should be updated: https://substrate.dev/rustdocs/v3.0.0/frame_support/attr.pallet.html#macro-expansion-2
frame/support/src/traits.rs
Outdated
| /// The block is being finalized. Implement to have something happen. | ||
| fn on_finalize(_n: BlockNumber) {} | ||
|
|
||
| /// The block is being finalized. Implement to have something happen using the remaining weight. |
Contributor
There was a problem hiding this comment.
I think you can copy/paste all the doc of OnIdle here and also link to it, something like:
"The function can be used to implement [OnIdle]."
Because pallet user probably want to read doc from this trait.
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
apopiak
reviewed
Mar 9, 2021
apopiak
reviewed
Mar 9, 2021
apopiak
reviewed
Mar 9, 2021
apopiak
reviewed
Mar 9, 2021
apopiak
reviewed
Mar 9, 2021
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
apopiak
approved these changes
Mar 11, 2021
Contributor
apopiak
left a comment
apopiak
left a comment
There was a problem hiding this comment.
LGTM, some minor docs nitpicks
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the on_idle hook as discussed in issue #4064