Self-sufficient account ref-counting by gavofyork · Pull Request #8221 · paritytech/substrate

gavofyork · 2021-02-27T16:02:16Z

Introduces a new ref-counted account type next to providers and consumers, called self-sufficient references. These allow an account to exist, but do not in themselves allow consumers to exist (for that there must be at least one provider reference on the account).

This is useful for times where you know that an aspect of an account is enough to pay for its basic existence, but where you want to guarantee that the reference can be yanked (probably by someone other than the account holder) without concern of there being consumers which depend on it.

Depended on by #8220

Requires audit.

Includes migration!

gavofyork · 2021-02-27T16:02:57Z

CC @xlc

frame/system/src/lib.rs

Co-authored-by: Jaco Greeff <jacogr@gmail.com>

bkchr · 2021-02-27T17:44:47Z

frame/system/src/lib.rs

-				migrations::migrate_to_dual_ref_count::<T>()
+			if !UpgradedToTripleRefCount::<T>::get() {
+				UpgradedToTripleRefCount::<T>::put(true);
+				migrations::migrate_to_triple_ref_count::<T>()


Can we not call the migration explicitly in the particular runtimes?

sure - i'm just concerned about it being forgotten.

xlc · 2021-02-27T21:55:45Z

I think I understand the purpose of this but still think the whole account ref system is under utilized & under documented. Will be helpful to have some guides to explain how it should be used along with examples. #5255

…/substrate into gav-self-sufficient-ref-count

frame/system/src/lib.rs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

shawntabrizi

lgtm

frame/system/src/lib.rs

kianenigma

Logic within the PR lgtm, haven't looked at the linked PR yet. I do agree with @xlc that a guide system refernces would be needed. I also have some doubts about why and how we increment them in some pallets and not in others (e.g. #7305)

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

paritytech/substrate#8221

(paritytech/substrate#8221)

* Remove VestingAccount * Fix chain specs * Update rust-toolchain * Update make test and benchmark * Update CI * Run `make format` and `make clippy` * Update CI * Quick fix * Support try-runtime * Remove pallet-randomness-collective-flip * Migrate elections-phragmen (paritytech/substrate#7040) * Migrate PalletVersion to StorageVersion (paritytech/substrate#9165) * Migrate pallet-babe epoch config (paritytech/substrate#8072) * Migrate frame-system AccountInfo to AccountInfoWithTripleRefCount (paritytech/substrate#8221) * Migrate prefix `GrandpaFinality` -> `Grandpa` * Migrate prefix `Instance1Collective` -> `Council` * Migrate prefix `Instance2Collective` -> `TechnicalCommittee` * Migrate prefix `Instance1Membership` -> `TechnicalMembership` * Migrate pallet-tips prefix from `Treasury` -> `Tips` * Migrate pallet-bounties prefix from `Treasury` -> `Bounties` * Migrate prefix from `PhragmenElection` -> `Elections` * Revert `dev` spec_name * Confirm migrations order * Use ChainX substrate patch for system migration * Run `make format` * Reset spec_name `dev` -> `chainx` * Add migrations.rs for mainnet and testnet * Bump ChainX version to `4.0.0` * Bump ChainX version to `4.0.0` * Update governance parameters for dev and malan * Update malan chainspec * Quick fix * Quick fix * Update generate_keys.sh * Adjust malan parameters * Update malan chainspec * Update malan chainspec * Update malan chainspec * Rename malan testnet name * Add bootnodes url * Run `make format` * Regenerate weights * Disable pre_release.yml CI * Regenerate benchmark weights * Run `make clippy` * Run `make format` Co-authored-by: icodezjb <icodezjb@users.noreply.github.com>

Self-sufficient account ref-counting

1a5e42c

gavofyork requested review from gui1117, kianenigma and shawntabrizi February 27, 2021 16:02

github-actions bot added the A0-please_review Pull request needs code review. label Feb 27, 2021

gavofyork added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Feb 27, 2021

gavofyork added the D1-runtime-migration label Feb 27, 2021

gavofyork mentioned this pull request Feb 27, 2021

Assets: Remove zombies, introduce approvals #8220

Merged

4 tasks

paritytech-ci added the D2-breaksapi label Feb 27, 2021

Fixes

fcaa301

jacogr reviewed Feb 27, 2021

View reviewed changes

frame/system/src/lib.rs Outdated Show resolved Hide resolved

Update frame/system/src/lib.rs

3902598

Co-authored-by: Jaco Greeff <jacogr@gmail.com>

jacogr mentioned this pull request Feb 27, 2021

AccountInfoWithTripleRefCount type & detection polkadot-js/api#3228

Merged

bkchr reviewed Feb 27, 2021

View reviewed changes

gavofyork added 6 commits February 28, 2021 09:19

Fixes

ba0740d

Merge branch 'gav-self-sufficient-ref-count' of github.com:paritytech…

b0a31da

…/substrate into gav-self-sufficient-ref-count

Fixes

3f55cf9

Fixes

b10e9ce

Fixes

fc2c8de

Fixes

e3db10c

github-actions bot added the A7-needspolkadotpr label Feb 28, 2021

gavofyork removed the A7-needspolkadotpr label Feb 28, 2021

gui1117 reviewed Mar 1, 2021

View reviewed changes

frame/system/src/lib.rs Show resolved Hide resolved

frame/system/src/lib.rs Show resolved Hide resolved

frame/system/src/lib.rs Show resolved Hide resolved

frame/system/src/lib.rs Show resolved Hide resolved

frame/system/src/lib.rs Outdated Show resolved Hide resolved

gavofyork and others added 3 commits March 2, 2021 13:22

Update frame/system/src/lib.rs

a31055f

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

Update frame/system/src/lib.rs

8dd46fc

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

Update frame/system/src/lib.rs

2f1e7ab

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

gavofyork and others added 2 commits March 2, 2021 13:25

Merge branch 'master' into gav-self-sufficient-ref-count

efaba28

fix build

73604cf

shawntabrizi approved these changes Mar 3, 2021

View reviewed changes

kianenigma reviewed Mar 3, 2021

View reviewed changes

frame/system/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Mar 3, 2021

View reviewed changes

gui1117 approved these changes Mar 3, 2021

View reviewed changes

Update frame/system/src/lib.rs

8568e79

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

gavofyork merged commit e2d74ac into master Mar 3, 2021

gavofyork deleted the gav-self-sufficient-ref-count branch March 3, 2021 21:28

xlc mentioned this pull request Mar 3, 2021

Revisit ref account usage AcalaNetwork/Acala#784

Open

arjanz added a commit to JAMdotTech/py-scale-codec that referenced this pull request Mar 5, 2021

Updated AccountInfo struct to support self-sufficient references

d45861f

paritytech/substrate#8221

shawntabrizi added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Apr 8, 2021

shawntabrizi mentioned this pull request Apr 8, 2021

Developer Documentation Needed on Proper Usage of Reference Counters polkadot-developers/substrate-developer-hub.github.io#965

Closed

pablojorge mentioned this pull request May 4, 2021

Support for runtime v30 splix/polkaj#53

Merged

natpopov mentioned this pull request Jun 9, 2021

Increase Existential Deposit and Review RefCount SpannerProtocol/spanner#38

Open

5 tasks

icodezjb mentioned this pull request Jan 27, 2022

Migrations from 11ace4ef8b2ad176293ad6db2b3dd795befd2c79 to polkadot-v0.9.11 of substrate chainx-org/ChainX#604

Closed

25 tasks

icodezjb added a commit to chainx-org/ChainX that referenced this pull request Feb 8, 2022

Migrate frame-system AccountInfo to AccountInfoWithTripleRefCount

8cb536b

(paritytech/substrate#8221)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Self-sufficient account ref-counting#8221

Self-sufficient account ref-counting#8221
gavofyork merged 15 commits intomasterfrom
gav-self-sufficient-ref-count

gavofyork commented Feb 27, 2021 •

edited

Loading

Uh oh!

gavofyork commented Feb 27, 2021

Uh oh!

Uh oh!

bkchr Feb 27, 2021

Uh oh!

gavofyork Feb 28, 2021

Uh oh!

xlc commented Feb 27, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shawntabrizi left a comment

Uh oh!

Uh oh!

kianenigma left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

gavofyork commented Feb 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gavofyork commented Feb 27, 2021

Uh oh!

Uh oh!

bkchr Feb 27, 2021

Choose a reason for hiding this comment

Uh oh!

gavofyork Feb 28, 2021

Choose a reason for hiding this comment

Uh oh!

xlc commented Feb 27, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shawntabrizi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

gavofyork commented Feb 27, 2021 •

edited

Loading